Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TVMC] --disable-pass option added to compile mode #7816

Merged
merged 4 commits into from
Apr 13, 2021
Merged

[TVMC] --disable-pass option added to compile mode #7816

merged 4 commits into from
Apr 13, 2021

Conversation

d-smirnov
Copy link
Contributor

Added --disable-pass option to TVMC compile mode to disallow certain supplied passes in PassContext for the compiler.

@d-smirnov d-smirnov force-pushed the tvmc-disabled-pass branch 2 times, most recently from 2f04b63 to 5346303 Compare April 9, 2021 16:32
comaniac
comaniac requested changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add test cases.

python/tvm/driver/tvmc/common.py Outdated Show resolved Hide resolved
python/tvm/driver/tvmc/common.py Outdated Show resolved Hide resolved
python/tvm/driver/tvmc/common.py Outdated Show resolved Hide resolved
python/tvm/driver/tvmc/compiler.py Outdated Show resolved Hide resolved
python/tvm/driver/tvmc/compiler.py Outdated Show resolved Hide resolved
python/tvm/driver/tvmc/compiler.py Outdated Show resolved Hide resolved
@comaniac comaniac self-assigned this Apr 9, 2021
@comaniac comaniac added status: need test case need test cases to cover the change status: need update need update based on feedbacks labels Apr 9, 2021
@comaniac
Copy link
Contributor

comaniac commented Apr 9, 2021

Also cc @leandron

@d-smirnov
[TVMC] --disable-pass option added to compile mode
d63f6b4 
Added --disable-pass option to TVMC compile mode to disallow
certain supplied passes in PassContext for the compiler.

Change-Id: Iae1849d7b051ac9288509dc458a58788c865537a
leandron
leandron reviewed Apr 9, 2021
View reviewed changes
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a some test cases.

python/tvm/driver/tvmc/compiler.py Show resolved Hide resolved
python/tvm/driver/tvmc/common.py Outdated Show resolved Hide resolved
@d-smirnov
Added test, addressed requests
1bc2e79 
Change-Id: If688f65441d3aa9967ab823adf899cfc704bd097
comaniac
comaniac approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please evaluate @leandron's comment of listing all available passes. We could skip that if it's too many as suggested.

@comaniac comaniac added status: accepted and removed status: need test case need test cases to cover the change status: need update need update based on feedbacks labels Apr 12, 2021
@d-smirnov
added printing of available passes
1506f4e 
Change-Id: I7a4706c03c0d64cade4977d431bcb25b3708f213
@d-smirnov
C0415(import-outside-toplevel)
85cc5f4 
Change-Id: I33d6f6f86d182de2e21e895ec2dfe9f11f5916dd
leandron
leandron approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering it is an advanced feature, and it is quite a big list of passes, I agree with your choice of showing it only when the user points to some pass that doesn't exist. LGTM.

@comaniac comaniac merged commit ef68e20 into apache:main Apr 13, 2021
@comaniac
Copy link
Contributor

Thanks @d-smirnov @leandron

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@d-smirnov
[TVMC] --disable-pass option added to compile mode (apache#7816)
67e656c 
* [TVMC] --disable-pass option added to compile mode

Added --disable-pass option to TVMC compile mode to disallow
certain supplied passes in PassContext for the compiler.

Change-Id: Iae1849d7b051ac9288509dc458a58788c865537a

* Added test, addressed requests

Change-Id: If688f65441d3aa9967ab823adf899cfc704bd097

* added printing of available passes

Change-Id: I7a4706c03c0d64cade4977d431bcb25b3708f213

* C0415(import-outside-toplevel)

Change-Id: I33d6f6f86d182de2e21e895ec2dfe9f11f5916dd
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@d-smirnov
[TVMC] --disable-pass option added to compile mode (apache#7816)
1907cfd 
* [TVMC] --disable-pass option added to compile mode

Added --disable-pass option to TVMC compile mode to disallow
certain supplied passes in PassContext for the compiler.

Change-Id: Iae1849d7b051ac9288509dc458a58788c865537a

* Added test, addressed requests

Change-Id: If688f65441d3aa9967ab823adf899cfc704bd097

* added printing of available passes

Change-Id: I7a4706c03c0d64cade4977d431bcb25b3708f213

* C0415(import-outside-toplevel)

Change-Id: I33d6f6f86d182de2e21e895ec2dfe9f11f5916dd
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@d-smirnov
[TVMC] --disable-pass option added to compile mode (apache#7816)
8719ec8 
* [TVMC] --disable-pass option added to compile mode

Added --disable-pass option to TVMC compile mode to disallow
certain supplied passes in PassContext for the compiler.

Change-Id: Iae1849d7b051ac9288509dc458a58788c865537a

* Added test, addressed requests

Change-Id: If688f65441d3aa9967ab823adf899cfc704bd097

* added printing of available passes

Change-Id: I7a4706c03c0d64cade4977d431bcb25b3708f213

* C0415(import-outside-toplevel)

Change-Id: I33d6f6f86d182de2e21e895ec2dfe9f11f5916dd
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
@d-smirnov @trevor-m
[TVMC] --disable-pass option added to compile mode (apache#7816)
3eac365 
* [TVMC] --disable-pass option added to compile mode

Added --disable-pass option to TVMC compile mode to disallow
certain supplied passes in PassContext for the compiler.

Change-Id: Iae1849d7b051ac9288509dc458a58788c865537a

* Added test, addressed requests

Change-Id: If688f65441d3aa9967ab823adf899cfc704bd097

* added printing of available passes

Change-Id: I7a4706c03c0d64cade4977d431bcb25b3708f213

* C0415(import-outside-toplevel)

Change-Id: I33d6f6f86d182de2e21e895ec2dfe9f11f5916dd
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandron leandron leandron approved these changes

@comaniac comaniac comaniac approved these changes

Assignees

@comaniac comaniac

Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-smirnov @comaniac @leandron