Update ICHECK error message with link to documentation page. #7869
Conversation
|
@mdw-octoml please fix the lint error, there is already an error handling doc here, would be great to merge the content with that one https://github.com/apache/tvm/blob/main/docs/contribute/error_handling.rst |
|
Fixed the lint error. The existing error handling doc is for TVM developers, not TVM users. (It is also fairly confusing and includes a lot of details that someone simply using TVM would not need to understand.) Rather than try to have a single doc for both audiences, I think it is best to keep the user documentation separate, so it is less confusing. I added a link from the new doc to the developer doc for those who want to understand the details of how errors are generated. Let me know what you think! |
|
Makes sense. Wonders if we can have a better tile. Since it is under how to section, perhaps |
|
I changed it to "What to do when encountering TVM errors" -- WDYT?
…On Mon, Apr 19, 2021 at 10:26 AM Tianqi Chen ***@***.***> wrote:
Makes sense. Wonders if we can have a better tile. Since it is under how
to section, perhaps Handle Errors. The flaky error is known in #7870
<#7870>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7869 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APEJO5BWVGOXDLKNHJE35STTJRRTRANCNFSM43CNTCQQ>
.
|
|
That sounds good |
|
@tkonolige, it looks like this PR hit an error in the VM RPC test. Maybe we need to bump up the delay in the test from 2 seconds to a little longer to guarantee stability? |
|
Yeah, try bumping it to something larger. |
|
I feel like that should be a separate PR. If you can tell me where to make
the change, I will, but in general one should avoid mixing unrelated
changes in a single PR.
…On Mon, Apr 19, 2021 at 6:08 PM Tristan Konolige ***@***.***> wrote:
Yeah, try bumping it to something larger.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7869 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APEJO5FMUWVSGG4T46LSSCLTJTH2XANCNFSM43CNTCQQ>
.
|
mdw-octoml
force-pushed
the
mdw/update-error-message
branch
from
6eb9509 to
7a3effd
Compare
|
I think I have resolved the merge issue, this should be good to land once CI passes. |
|
Thanks @mdw-octoml for contributing. Thanks @michalpiszczek @jwfromm for reviewing |
tqchen
added
status: accepted
and removed
status: need update
This PR updates the error message emitted by ICHECK failures to point to a documentation page, which we can update over time with more information on common failure cases and hints on how to resolve them. Welcome comments on the exact wording and the content of the documentation page.