-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NVCC] Bugfix nvcc command tool that relies on the compile time env #7964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comaniac
approved these changes
May 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
umangyadav
pushed a commit
to umangyadav/tvm
that referenced
this pull request
May 5, 2021
…pache#7964) * [NVCC] Bugfix nvcc command tool that relies on the compile time env * Update python/tvm/contrib/nvcc.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…pache#7964) * [NVCC] Bugfix nvcc command tool that relies on the compile time env * Update python/tvm/contrib/nvcc.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…pache#7964) * [NVCC] Bugfix nvcc command tool that relies on the compile time env * Update python/tvm/contrib/nvcc.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…pache#7964) * [NVCC] Bugfix nvcc command tool that relies on the compile time env * Update python/tvm/contrib/nvcc.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…pache#7964) * [NVCC] Bugfix nvcc command tool that relies on the compile time env * Update python/tvm/contrib/nvcc.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TVM_CXX_COMPILER_PATH indicates the env in compilation and do not guarantee to exist in runtime. Right now it becomes a problem if when build on centos(manylinux wheel) and run on ubuntu