Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NVCC] Bugfix nvcc command tool that relies on the compile time env #7964

Merged
merged 2 commits into from
May 3, 2021

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented May 2, 2021

TVM_CXX_COMPILER_PATH indicates the env in compilation and do not guarantee to exist in runtime. Right now it becomes a problem if when build on centos(manylinux wheel) and run on ubuntu

@tqchen
Copy link
Member Author

tqchen commented May 2, 2021

cc @rkimball @junrushao1994

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/tvm/contrib/nvcc.py Outdated Show resolved Hide resolved
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
@masahi masahi merged commit dd5379f into apache:main May 3, 2021
umangyadav pushed a commit to umangyadav/tvm that referenced this pull request May 5, 2021
…pache#7964)

* [NVCC] Bugfix nvcc command tool that relies on the compile time env

* Update python/tvm/contrib/nvcc.py

Co-authored-by: Cody Yu <comaniac0422@gmail.com>

Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
…pache#7964)

* [NVCC] Bugfix nvcc command tool that relies on the compile time env

* Update python/tvm/contrib/nvcc.py

Co-authored-by: Cody Yu <comaniac0422@gmail.com>

Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
…pache#7964)

* [NVCC] Bugfix nvcc command tool that relies on the compile time env

* Update python/tvm/contrib/nvcc.py

Co-authored-by: Cody Yu <comaniac0422@gmail.com>

Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
…pache#7964)

* [NVCC] Bugfix nvcc command tool that relies on the compile time env

* Update python/tvm/contrib/nvcc.py

Co-authored-by: Cody Yu <comaniac0422@gmail.com>

Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
…pache#7964)

* [NVCC] Bugfix nvcc command tool that relies on the compile time env

* Update python/tvm/contrib/nvcc.py

Co-authored-by: Cody Yu <comaniac0422@gmail.com>

Co-authored-by: Cody Yu <comaniac0422@gmail.com>
@tqchen tqchen deleted the nvcc branch February 26, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants