-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BYOC] Remove ext params stored in metadata from params to avoid duplication #7977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks clean and good to me. Could you add a test case?
Thanks @comaniac
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d478d7d
to
a51517c
Compare
a51517c
to
a80115f
Compare
Thanks @trevor-m |
…ication (apache#7977) * Remove ext params stored in metadata from params to avoid duplication * Add test for duplicate params
…ication (apache#7977) * Remove ext params stored in metadata from params to avoid duplication * Add test for duplicate params
…ication (apache#7977) * Remove ext params stored in metadata from params to avoid duplication * Add test for duplicate params
…ication (apache#7977) * Remove ext params stored in metadata from params to avoid duplication * Add test for duplicate params
This PR is an alternative to #7564
During compilation, weights from external modules are stored in the MetadataModule (.so), but they are still kept in params so they end up being duplicated.
This PR will remove from params only the weights which were stored in MetadataModule, solving the weight duplication issue.