-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autoscheduler] Add sparse conv2d(1*1) support for auto_scheduler #8065
Conversation
Also cc @tkonolige |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me.
Thanks! @yuchaoli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments, but it mostly looks good to me.
|
||
bool SparseConv2dRel(const Array<Type>& types, int num_inputs, const Attrs& attrs, | ||
const TypeReporter& reporter) { | ||
ICHECK_EQ(types.size(), 5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an error message.
Merged. Thanks! @yuchaoli @tkonolige |
…ache#8065) * add sparse conv2d support for auto_scheduler * add description * fix bug * fix annotation * Lint fix Co-authored-by: laiyin.lyc <laiyin.lyc@alibaba-inc.com>
…ache#8065) * add sparse conv2d support for auto_scheduler * add description * fix bug * fix annotation * Lint fix Co-authored-by: laiyin.lyc <laiyin.lyc@alibaba-inc.com>
This pull request adds sparse conv2d(1*1) support for auto_scheduler. I have implemented sparse conv2d with kernel_size=1, using the BSR sparse data format.
I evaluate the performance of sparse conv2d by mobilenet_v2 in pixel2. All of 1*1 conv2d in the network are transformed into sparse conv2d with block_size=(4, 1).
@jcf94