Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VM, Profiling] Add function attribute for shape func for profiling #8148

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

masahi
Copy link
Member

@masahi masahi commented May 27, 2021

#7894 forgot to add func attributes for shape func, and so the profiler crashes at

auto& op_attrs = exec_->op_attrs.at(packed_index);
when it tries to run a shape func on dynamic workloads.

cc @tkonolige @junrushao1994

Copy link
Contributor

@tkonolige tkonolige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Thanks!

@masahi
Copy link
Member Author

masahi commented May 30, 2021

Ready to merge @tqchen @junrushao1994

@mbrookhart mbrookhart merged commit bc785de into apache:main Jun 1, 2021
@mbrookhart
Copy link
Contributor

Thanks @masahi @tkonolige

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants