[METAL] Fix the rest memory leaks in Metal runtime #8175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we throw exception from autoreleasepool, then the resources won't be released in proper way. In the documentation we can see that "When the block is exited with an exception, the pool is not drained.". Link on the documentation: https://clang.llvm.org/docs/AutomaticReferenceCounting.html#autoreleasepool Implemented a wrapper which handles all exceptions in autoreleasepool block and throw them after this block.
echuraev
force-pushed
the
echuraev/fix_metal_runtime_mem_leak
branch
from
8be3271
to
458be49
Compare
elvin-n
reviewed
Jun 3, 2021
tqchen
approved these changes
Jun 4, 2021
tqchen
reviewed
Jun 4, 2021
|
Thank you @echuraev |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
* [METAL] Fix the rest memory leaks in Metal runtime When we throw exception from autoreleasepool, then the resources won't be released in proper way. In the documentation we can see that "When the block is exited with an exception, the pool is not drained.". Link on the documentation: https://clang.llvm.org/docs/AutomaticReferenceCounting.html#autoreleasepool Implemented a wrapper which handles all exceptions in autoreleasepool block and throw them after this block. * Apply comments * Add documentation comments to wrapper and macro
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
* [METAL] Fix the rest memory leaks in Metal runtime When we throw exception from autoreleasepool, then the resources won't be released in proper way. In the documentation we can see that "When the block is exited with an exception, the pool is not drained.". Link on the documentation: https://clang.llvm.org/docs/AutomaticReferenceCounting.html#autoreleasepool Implemented a wrapper which handles all exceptions in autoreleasepool block and throw them after this block. * Apply comments * Add documentation comments to wrapper and macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we throw exception from autoreleasepool, then the resources won't
be released in proper way. In the documentation we can see that "When
the block is exited with an exception, the pool is not drained.".
Link on the documentation:
https://clang.llvm.org/docs/AutomaticReferenceCounting.html#autoreleasepool
Implemented a wrapper which handles all exceptions in autoreleasepool
block and throw them after this block.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.