[Frontend, Tensorflow, Tensorflow2] Tensorflow frontend op refactor #8179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rohan Mukherjee <mukrohan@amazon.com> Co-authored-by: David Huang <davhuan@amazon.com> Co-authored-by: Xingyu Zhou <zhoxingy@amazon.com> Co-authored-by: Srinidhi Goud <srinidhi.goud29@gmail.com> Co-authored-by: Xiao <weix@amazon.com>
Co-authored-by: Xingyu Zhou <zhoxingy@amazon.com> Co-authored-by: Rohan Mukherjee <mukrohan@amazon.com> Co-authored-by: David Huang <davhuan@amazon.com> Co-authored-by: Srinidhi Goud <srinidhi.goud29@gmail.com> Co-authored-by: Xiao <weix@amazon.com>
rohanmukh
force-pushed
the
tf2_op_refactor
branch
from
02c1d03
to
7106b39
Compare
rohanmukh
changed the title
rohanmukh
changed the title
Author: Masahiro Masuda <masahi129@gmail.com> Co-authored-by: Masahiro Masuda <masahi129@gmail.com>
Co-authored-by: Rohan Mukherjee <mukrohan@amazon.com> Co-authored-by: Xingyu Zhou <zhoxingy@amazon.com> Co-authored-by: David Huang <davhuan@amazon.com> Co-authored-by: Srinidhi Goud <srinidhi.goud29@gmail.com> Co-authored-by: Xiao <weix@amazon.com>
FrozenGene
approved these changes
Jun 10, 2021
|
Thanks @rohanmukh @trevor-m TF2 is one important frontend for TVM users. Great work and let us go on! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
…pache#8179) * Refactoring the ops from Tf1 frontend Co-authored-by: Rohan Mukherjee <mukrohan@amazon.com> Co-authored-by: David Huang <davhuan@amazon.com> Co-authored-by: Xingyu Zhou <zhoxingy@amazon.com> Co-authored-by: Srinidhi Goud <srinidhi.goud29@gmail.com> Co-authored-by: Xiao <weix@amazon.com> * Resolving an import bug and refactor Co-authored-by: Xingyu Zhou <zhoxingy@amazon.com> Co-authored-by: Rohan Mukherjee <mukrohan@amazon.com> Co-authored-by: David Huang <davhuan@amazon.com> Co-authored-by: Srinidhi Goud <srinidhi.goud29@gmail.com> Co-authored-by: Xiao <weix@amazon.com> * Tf2 frontend importing from common ops * linting and unused imports fix * Applying changes from commit id f4ec5fd Author: Masahiro Masuda <masahi129@gmail.com> Co-authored-by: Masahiro Masuda <masahi129@gmail.com> * Minor linting Co-authored-by: Rohan Mukherjee <mukrohan@amazon.com> Co-authored-by: Xingyu Zhou <zhoxingy@amazon.com> Co-authored-by: David Huang <davhuan@amazon.com> Co-authored-by: Srinidhi Goud <srinidhi.goud29@gmail.com> Co-authored-by: Xiao <weix@amazon.com> Co-authored-by: David Huang <davhuan@amazon.com> Co-authored-by: Xingyu Zhou <zhoxingy@amazon.com> Co-authored-by: Srinidhi Goud <srinidhi.goud29@gmail.com> Co-authored-by: Xiao <weix@amazon.com> Co-authored-by: Masahiro Masuda <masahi129@gmail.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
…pache#8179) * Refactoring the ops from Tf1 frontend Co-authored-by: Rohan Mukherjee <mukrohan@amazon.com> Co-authored-by: David Huang <davhuan@amazon.com> Co-authored-by: Xingyu Zhou <zhoxingy@amazon.com> Co-authored-by: Srinidhi Goud <srinidhi.goud29@gmail.com> Co-authored-by: Xiao <weix@amazon.com> * Resolving an import bug and refactor Co-authored-by: Xingyu Zhou <zhoxingy@amazon.com> Co-authored-by: Rohan Mukherjee <mukrohan@amazon.com> Co-authored-by: David Huang <davhuan@amazon.com> Co-authored-by: Srinidhi Goud <srinidhi.goud29@gmail.com> Co-authored-by: Xiao <weix@amazon.com> * Tf2 frontend importing from common ops * linting and unused imports fix * Applying changes from commit id f4ec5fd Author: Masahiro Masuda <masahi129@gmail.com> Co-authored-by: Masahiro Masuda <masahi129@gmail.com> * Minor linting Co-authored-by: Rohan Mukherjee <mukrohan@amazon.com> Co-authored-by: Xingyu Zhou <zhoxingy@amazon.com> Co-authored-by: David Huang <davhuan@amazon.com> Co-authored-by: Srinidhi Goud <srinidhi.goud29@gmail.com> Co-authored-by: Xiao <weix@amazon.com> Co-authored-by: David Huang <davhuan@amazon.com> Co-authored-by: Xingyu Zhou <zhoxingy@amazon.com> Co-authored-by: Srinidhi Goud <srinidhi.goud29@gmail.com> Co-authored-by: Xiao <weix@amazon.com> Co-authored-by: Masahiro Masuda <masahi129@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the current
tensorflow.pyparser and separates the code for the ops into a separate filetensorflow_ops.py. The new parser for handling tensorflow2 models in TVM, ietensorflow2.py, imports the existing frontend op codes fromtensorflow.py. With the current PR both of these frontend codes will import the ops from a common file for the ops intensorflow_ops.py.This PR is in line with the original plan of supporting tensorflow2 parser in TVM frontend as in the discussion #4102 Exact commit plan here.
Co-authored-by: Rohan Mukherjee mukrohan@amazon.com
Co-authored-by: Xingyu Zhou zhoxingy@amazon.com
Co-authored-by: David Huang davhuan@amazon.com
Co-authored-by: Srinidhi Goud srinidhi.goud29@gmail.com
Co-authored-by: Xiao weix@amazon.com
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.