[Vulkan][Refactor] Pull out vulkan initialization into VulkanInstance and VulkanDevice #8188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lass. - Previously, the VkInstance was directly owned by the VulkanDeviceAPI. Now, VulkanDeviceAPI owns a tvm::runtime::vulkan::VulkanInstance that does setup/teardown of the VkInstance. This way, the teardown is done even if a later initialization step throws an exception.
Renaming to match with the tvm.context to tvm.device rename.
…able from VulkanDevice - Now that there is a separate VulkanDeviceProperties class, the redundant VkPhysicalDeviceProperties can be removed.
|
Potential reviewers: @masahi @tmoreau89 |
masahi
approved these changes
Jun 4, 2021
|
thanks @Lunderberg |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
… and VulkanDevice (apache#8188) * [Vulkan][Refactor] Broke out VkInstance setup/teardown into managed class. - Previously, the VkInstance was directly owned by the VulkanDeviceAPI. Now, VulkanDeviceAPI owns a tvm::runtime::vulkan::VulkanInstance that does setup/teardown of the VkInstance. This way, the teardown is done even if a later initialization step throws an exception. * [Vulkan] Renamed VulkanContext to VulkanDevice Renaming to match with the tvm.context to tvm.device rename. * [Vulkan][Refactor] Extracted VulkanDevice initialization into VulkanDevice class * [Vulkan][Refactor] Removed the VkPhysicalDeviceProperties member variable from VulkanDevice - Now that there is a separate VulkanDeviceProperties class, the redundant VkPhysicalDeviceProperties can be removed. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
… and VulkanDevice (apache#8188) * [Vulkan][Refactor] Broke out VkInstance setup/teardown into managed class. - Previously, the VkInstance was directly owned by the VulkanDeviceAPI. Now, VulkanDeviceAPI owns a tvm::runtime::vulkan::VulkanInstance that does setup/teardown of the VkInstance. This way, the teardown is done even if a later initialization step throws an exception. * [Vulkan] Renamed VulkanContext to VulkanDevice Renaming to match with the tvm.context to tvm.device rename. * [Vulkan][Refactor] Extracted VulkanDevice initialization into VulkanDevice class * [Vulkan][Refactor] Removed the VkPhysicalDeviceProperties member variable from VulkanDevice - Now that there is a separate VulkanDeviceProperties class, the redundant VkPhysicalDeviceProperties can be removed. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step of the refactoring initiated in #8157. Each of the following changes is implemented in a separate commit in this PR.
Broke out
VkInstancesetup/teardown into managed class. Previously, theVkInstancewas directly owned by theVulkanDeviceAPI. Now,VulkanDeviceAPIowns atvm::runtime::vulkan::VulkanInstancethat does setup/teardown of theVkInstance. This way, the teardown is done even if a later initialization step throws an exception.Renamed
VulkanContexttoVulkanDevice, to match with thetvm.contexttotvm.devicerename.Extracted
VulkanDeviceinitialization intoVulkanDeviceclassRemoved the
VkPhysicalDevicePropertiesmember variable fromVulkanDevice. With the separateVulkanDevicePropertiesclass, this moves all device parameter query/access to a single path.