[UnitTests] Added cuDNN to default test targets #8383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
force-pushed
the
tvm_testing_default_targets
branch
from
04a36d4 to
1a2838e
Compare
|
Updated to fix pylint error. |
Lunderberg
force-pushed
the
tvm_testing_default_targets
branch
2 times, most recently
from
b6fb4d9 to
f57debb
Compare
|
Current failures.
|
Lunderberg
force-pushed
the
tvm_testing_default_targets
branch
from
f57debb to
0ab1190
Compare
Lunderberg
requested review from
areusch,
comaniac,
jroesch,
junrushao,
kparzysz-quic,
masahi,
merrymercy,
tqchen,
vinx13,
yzhliu,
zhiics and
ZihengJiang
as code owners
comaniac
approved these changes
Jul 22, 2021
python/tvm/testing.py
Outdated
Comment on lines
383
to
384
| if len(target_names) == 0: | ||
| target_names = DEFAULT_TEST_TARGETS |
There was a problem hiding this comment.
nit
Suggested change
| if len(target_names) == 0: | |
| target_names = DEFAULT_TEST_TARGETS | |
| if not target_names: | |
| target_names = DEFAULT_TEST_TARGETS |
There was a problem hiding this comment.
Good call, and updated.
Lunderberg
force-pushed
the
tvm_testing_default_targets
branch
4 times, most recently
from
80db1a3 to
4df4417
Compare
Lunderberg
force-pushed
the
tvm_testing_default_targets
branch
from
4df4417 to
93a9535
Compare
…arget - Read target.kind.name instead of using string manipulation. - Target device query on a non-existent target is no longer an error. This occurs if expanding `vulkan -from_device=0` on a non-GPU machine.
Some unit tests explicitly test cudnn in addition to `tvm.testing.enabled_targets()`. This moved the cudnn checks into the same framework as all other targets, and adds it to the default list of targets to be run. Also, added `@tvm.testing.requires_cudnn` for tests specific to cudnn.
Lunderberg
force-pushed
the
tvm_testing_default_targets
branch
from
93a9535 to
3d2d719
Compare
Lunderberg
requested review from
Huyuwei,
jcf94,
jwfromm,
kevinthesun,
Laurawly and
mbrookhart
as code owners
|
Hopefully the last update needed here, rebased to main and fixed an issue with the conv2d_cudnn handling of dilation. |
Previously, cuda/nvptx targets were excluded. Changed it to look up by target.kind.name, and to also exclude vulkan/opencl, as the dynamic lookup currently doesn't work on those backends.
This was referenced Aug 9, 2021
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Aug 11, 2021
* [Target][UnitTests] Look up target requirements based on tvm.target.Target - Read target.kind.name instead of using string manipulation. - Target device query on a non-existent target is no longer an error. This occurs if expanding `vulkan -from_device=0` on a non-GPU machine. * [UnitTests] Added cuDNN target to default test targets Some unit tests explicitly test cudnn in addition to `tvm.testing.enabled_targets()`. This moved the cudnn checks into the same framework as all other targets, and adds it to the default list of targets to be run. Also, added `@tvm.testing.requires_cudnn` for tests specific to cudnn. * [UnitTests] pytest.xfail for CuDNN conv2d with asymmetric padding * [Topi][CuDNN] Added handling of dilation to conv2d_cudnn * [Topi] Skip dynamic batch matmul on cudnn, vulkan, opencl Previously, cuda/nvptx targets were excluded. Changed it to look up by target.kind.name, and to also exclude vulkan/opencl, as the dynamic lookup currently doesn't work on those backends. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* [Target][UnitTests] Look up target requirements based on tvm.target.Target - Read target.kind.name instead of using string manipulation. - Target device query on a non-existent target is no longer an error. This occurs if expanding `vulkan -from_device=0` on a non-GPU machine. * [UnitTests] Added cuDNN target to default test targets Some unit tests explicitly test cudnn in addition to `tvm.testing.enabled_targets()`. This moved the cudnn checks into the same framework as all other targets, and adds it to the default list of targets to be run. Also, added `@tvm.testing.requires_cudnn` for tests specific to cudnn. * [UnitTests] pytest.xfail for CuDNN conv2d with asymmetric padding * [Topi][CuDNN] Added handling of dilation to conv2d_cudnn * [Topi] Skip dynamic batch matmul on cudnn, vulkan, opencl Previously, cuda/nvptx targets were excluded. Changed it to look up by target.kind.name, and to also exclude vulkan/opencl, as the dynamic lookup currently doesn't work on those backends. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [Target][UnitTests] Look up target requirements based on tvm.target.Target - Read target.kind.name instead of using string manipulation. - Target device query on a non-existent target is no longer an error. This occurs if expanding `vulkan -from_device=0` on a non-GPU machine. * [UnitTests] Added cuDNN target to default test targets Some unit tests explicitly test cudnn in addition to `tvm.testing.enabled_targets()`. This moved the cudnn checks into the same framework as all other targets, and adds it to the default list of targets to be run. Also, added `@tvm.testing.requires_cudnn` for tests specific to cudnn. * [UnitTests] pytest.xfail for CuDNN conv2d with asymmetric padding * [Topi][CuDNN] Added handling of dilation to conv2d_cudnn * [Topi] Skip dynamic batch matmul on cudnn, vulkan, opencl Previously, cuda/nvptx targets were excluded. Changed it to look up by target.kind.name, and to also exclude vulkan/opencl, as the dynamic lookup currently doesn't work on those backends. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some unit tests explicitly test cudnn in addition to tvm.testing.enabled_targets(). This moved the cudnn checks into the same framework as all other targets, and adds it to the default list of targets to be run. Also, added
@tvm.testing.requires_cudnnfor tests specific to cudnn.In principle, this should pass CI, since any non-cudnn tests can fall back to the cuda implementation, but "should" is a bit of a magic word.