Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing annotation for requires_gpu in test_topi_dense.py #8387

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Add missing annotation for requires_gpu in test_topi_dense.py #8387

merged 1 commit into from
Jul 2, 2021

Conversation

u99127
Copy link
Contributor

@u99127 u99127 commented Jul 2, 2021

Add missing Requires GPU on this test as this fails when topi tests are run on CPUs without GPUs.

leandron
leandron approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leandron
Copy link
Contributor

leandron commented Jul 2, 2021

cc @Lunderberg

@leandron leandron merged commit 354d996 into apache:main Jul 2, 2021
@leandron
Copy link
Contributor

leandron commented Jul 2, 2021

This is merged now, thanks @u99127!

@Lunderberg
Copy link
Contributor

Thank you @u99127 for finding this. In principle, the parametrized target value is supposed to apply the requires_gpu annotation for any gpu targets, but it looks like the use of pytest.mark.parametrize skipped past that feature. I'll see what I can do to make it more robust against such issues in the future.

@Lunderberg Lunderberg mentioned this pull request Jul 23, 2021
Merged
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@ylc
Add missing annotation for requires_gpu in test_topi_dense.py Require…
417d815 
…s GPU (apache#8387)
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
@ylc
Add missing annotation for requires_gpu in test_topi_dense.py Require…
58096e1 
…s GPU (apache#8387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandron leandron leandron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@u99127 @leandron @Lunderberg