Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Actually add Compute Library tests to the Jenkins File (#8394)" #8400

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

u99127
Copy link
Contributor

@u99127 u99127 commented Jul 4, 2021

This reverts commit a00d211 till we
can understand why this is failing in CI but not on developer machines.

@tqchen @leandron @masahi

Sorry about the breakage but here's a revert if that can be merged asap.

@leandron
Copy link
Contributor

leandron commented Jul 5, 2021

I'm not 100% sure that #8394 needs to be reverted, considering that there is evidence of the tests passing today: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-8402/3/pipeline.

It might as well be a transient. Needs investigation, but maybe doesn't justify reverting that PR as a whole.

@u99127
Copy link
Contributor Author

u99127 commented Jul 5, 2021

I did see another of my PRs fail yesterday with the same sort of failure -.https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-8400/1/pipeline

I've tried respinning that one.

Lets hope it is transient 🤞

@u99127
Copy link
Contributor Author

u99127 commented Jul 5, 2021

I think this should be dropped as the CI appears to be holding.

@u99127
Copy link
Contributor Author

u99127 commented Jul 5, 2021

Lets not merge this if CI holds - I'll leave it here for a day or so before Closing this out.

@masahi
Copy link
Member

masahi commented Jul 7, 2021

@electriclilies
Copy link
Contributor

electriclilies commented Jul 7, 2021

I also hit the failure today https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-7518/79/pipeline/
The error I'm seeing is different from @masahi's but it's the same test that is failing.

cc @jroesch @areusch @csullivan

@tqchen
Copy link
Member

tqchen commented Jul 7, 2021

we require the jenkinsfile to be in main in order to take effect. please send a PR to first cleanup the arm_compute_lib.sh to be an empty shell script, then we can merge and delete the step

As a part of that, it might be easier in the future to add the tests to

@tqchen
Copy link
Member

tqchen commented Jul 7, 2021

tracking issue #8417

Ramana Radhakrishnan added 2 commits July 7, 2021 16:04
…e#8394)"

This reverts commit a00d211 till we
can understand why this is failing in CI but not on developer machines.
Change-Id: I142411ac132e566286f107666be85c3ce9081423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants