Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyLint] Minor updates to pass pylint locally. #8424

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

Lunderberg
Copy link
Contributor

With either the ci_lint docker image, or the matched version of pylint==2.4.4, I get two lint errors running locally that didn't show up in the CI. This commit fixes those two, both of which are import orderings.

With either the ci_lint docker image, or the matched version of
pylint==2.4.4, I got two lint errors running locally that didn't show
up in the CI.  Fixing them.
Copy link
Contributor

@jcf94 jcf94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @Lunderberg

@jcf94 jcf94 merged commit ee65ab7 into apache:main Jul 9, 2021
@Lunderberg Lunderberg deleted the pylint_fixes branch July 9, 2021 03:18
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
With either the ci_lint docker image, or the matched version of
pylint==2.4.4, I got two lint errors running locally that didn't show
up in the CI.  Fixing them.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
With either the ci_lint docker image, or the matched version of
pylint==2.4.4, I got two lint errors running locally that didn't show
up in the CI.  Fixing them.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants