[Relay][Onnx][Frontend] Add RandomUniform converter and tests to onnx frontend. #8426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
approved these changes
Jul 8, 2021
AndrewZhaoLuo
requested changes
Jul 8, 2021
|
@mbrookhart it looks like this hit a flaky GPU test for |
jwfromm
force-pushed
the
onnx_random_uniform
branch
from
b5e79f9
to
c7680f4
Compare
|
Oh neat, thanks! |
jwfromm
force-pushed
the
onnx_random_uniform
branch
from
c7680f4
to
8d91a22
Compare
emijiayw
reviewed
Jul 12, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
… frontend. (apache#8426) * Add RandomUniform converter and tests to onnx frontend. * Fix comments. * Remove weird import. * Add test against golden array. * Retrigger CI * Improve test comment. * Retrigger CI.
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
… frontend. (apache#8426) * Add RandomUniform converter and tests to onnx frontend. * Fix comments. * Remove weird import. * Add test against golden array. * Retrigger CI * Improve test comment. * Retrigger CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a converter for the Onnx RandomUniform operator using the recently added PRNG kernels. Note that since it's random, it's difficult to compare correctness to onnxruntime. Instead I confirm basic properties of the produced values. Please let me know if there are better tests that we could perform.