[TensorIR][M2a] Fuse, Split #8467
Conversation
| @@ -881,7 +883,7 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const FloorModNode* op) { | |||
|
|
|||
| TVM_TRY_REWRITE_IF(floormod(x + y * c1, c2), floormod(x, c2), | |||
| c2.Eval()->value > 0 && c1.Eval()->value % c2.Eval()->value == 0); | |||
|
|
|||
| TVM_TRY_REWRITE_IF(floormod(x * c1, x * c2), x * floormod(c1, c2), c2.Eval()->value != 0); | |||
There was a problem hiding this comment.
Please send this as separate PR with regression testcases.
There was a problem hiding this comment.
These lines are added to support symbolic split/fuse in some simple cases, but it still can't handle situations where there are 2 or more symbolic vars. Do you think we should support this simple situation for now by merging it in a new PR or we put it aside and support the complete symbolic usage after we improve symbolic divisible check in iter_affine_map?
There was a problem hiding this comment.
@tqchen @junrushao1994 what's your opinion on this?
|
CC @spectrometerHBH please take a look at the iter-affine-map part |
|
I have addressed all the comments. Please have another look. |
|
Comments are addressed. Please have another round of review! |
|
Thanks for your patience! I don't have other comments |
jinhongyii
requested review from
areusch,
icemelon,
jroesch,
merrymercy,
yzhliu and
zhiics
as code owners
|
Sorry for bothering you. I don't know what happened and I don't know how to cancel it. |
|
@junrushao1994 I've addressed your new comments |
* Fuse&split (apache#408) Co-authored-by: jinhongyi <323195289@qq.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com>
* Fuse&split (apache#408) Co-authored-by: jinhongyi <323195289@qq.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com>
This PR is part of the TensorIR upstreaming effort (#7527) , which adds 2 schedule primitives: