Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AOT][Stack Allocator] Fix Initial Memory Misalignment #8487

Merged
merged 16 commits into from
Jul 30, 2021

Conversation

mehrdadh
Copy link
Member

This PR:

  • Changes StackMemoryManager_Init to align the initial AOT memory misalignment
  • Adds cpp test for this bug

This PR is for fixing issues like this: #8474

@mehrdadh
Copy link
Member Author

cc @manupa-arm @areusch @gromero

tests/crt/aot_memory_test.cc Outdated Show resolved Hide resolved
tests/crt/aot_memory_test.cc Show resolved Hide resolved
tests/crt/aot_memory_test.cc Outdated Show resolved Hide resolved
src/runtime/crt/memory/stack_allocator.c Outdated Show resolved Hide resolved
tests/crt/aot_memory_test.cc Show resolved Hide resolved
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mehrdadh just a few more things

tests/crt/aot_memory_test.cc Outdated Show resolved Hide resolved
tests/crt/aot_memory_test.cc Outdated Show resolved Hide resolved
tests/crt/aot_memory_test.cc Outdated Show resolved Hide resolved
tests/crt/aot_memory_test.cc Outdated Show resolved Hide resolved
src/runtime/crt/memory/stack_allocator.c Outdated Show resolved Hide resolved
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mehrdadh !

@areusch
Copy link
Contributor

areusch commented Jul 27, 2021

looks like this one ran into a CI bug, can you sync?

@areusch areusch merged commit 2b94a7e into apache:main Jul 30, 2021
@mehrdadh mehrdadh deleted the zephyr_memory_alignment branch August 2, 2021 21:12
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* add flag

* fix and test

* format

* fix memory memory_align function

* fix and address comments

* format

* fix crt aot test

* comments

* fix test

* trigger

* trigger

* trigger

* trigger

* trigger

Co-authored-by: Mehrdad Hessar <mhessar@ip-172-31-20-199.us-west-2.compute.internal>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* add flag

* fix and test

* format

* fix memory memory_align function

* fix and address comments

* format

* fix crt aot test

* comments

* fix test

* trigger

* trigger

* trigger

* trigger

* trigger

Co-authored-by: Mehrdad Hessar <mhessar@ip-172-31-20-199.us-west-2.compute.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants