Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TensorRT, BYOC] Handling a corner case in TRT RemoveDropout pass #8506

Merged
merged 2 commits into from
Jul 28, 2021
Merged

[TensorRT, BYOC] Handling a corner case in TRT RemoveDropout pass #8506

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6aba042
[TensorRT, BYOC] Handling a corner case in TRT RemoveDropout pass
rohanmukh Jul 16, 2021
4908819
changing visit logic
rohanmukh Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/tvm/relay/op/contrib/tensorrt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
from tvm import relay
from tvm.relay import transform
from tvm.relay.build_module import bind_params_by_name
from tvm.relay.expr import Call, Constant, Tuple, GlobalVar, Var, TupleGetItem
from tvm.relay.expr import Call, Constant, Tuple, GlobalVar, Var, TupleGetItem, Let
from tvm.relay.expr_functor import ExprMutator, ExprVisitor

logger = logging.getLogger("TensorRT")
Expand Down Expand Up @@ -1033,6 +1033,8 @@ def visit_tuple_getitem(self, op):
visit = super().visit_tuple_getitem(op)
if visit.index != 0:
return visit
if isinstance(visit.tuple_value, Call) and isinstance(visit.tuple_value.op, Let):
return visit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a bit ad-hoc to me. Suggest as follows. Note that I'm not sure if isinstance(visit.tuple_value.op, Op) is the correct expression but you should know what I meant.

if isinstance(visit.tuple_value, Call):
  if isinstance(visit.tuple_value.op, Op) and visit.tuple_value.op.name == "nn.dropout" and visit.index == 0:
    return visit.tuple_value.args[0]
return visit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @comaniac . Changed the logic as appropriate.

if (
isinstance(visit.tuple_value, Call)
and visit.tuple_value.op.name == "nn.dropout"
Expand Down