[Refactor] Remove AttrStmt with storage_scope key #8516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
force-pushed
the
remove_attr_storage_scope
branch
from
059f41a
to
5009d78
Compare
|
cc @kparzysz-quic would be great if you can help to manage this PR |
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Jul 22, 2021
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Jul 22, 2021
masahi
requested review from
anijain2305,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
kparzysz-quic,
MarisaKirisame,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
|
This is ready for review @tqchen @kparzysz-quic @vinx13 @csullivan |
masahi
commented
Jul 22, 2021
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Jul 24, 2021
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Jul 24, 2021
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Jul 25, 2021
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Jul 25, 2021
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Jul 25, 2021
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Jul 27, 2021
masahi
force-pushed
the
remove_attr_storage_scope
branch
2 times, most recently
from
816f272
to
6815973
Compare
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Jul 27, 2021
kparzysz-quic
approved these changes
Jul 27, 2021
masahi
force-pushed
the
remove_attr_storage_scope
branch
from
edade29
to
58841ac
Compare
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Jul 28, 2021
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Jul 28, 2021
masahi
force-pushed
the
remove_attr_storage_scope
branch
from
58841ac
to
64e1bee
Compare
|
Thanks @masahi! |
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Jul 29, 2021
masahi
added a commit
to masahi/tvm
that referenced
this pull request
Jul 29, 2021
masahi
added a commit
that referenced
this pull request
Jul 30, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* Remove all attr::storage_scope usage * pyformat * fixed VTA tests * Update TIR text printer to print storage_scope on allocate * print storage scope in AllocateNode ReprPrinter * Fixed accidently removed scope tag check * remove unused function Co-authored-by: masa <masa@pop-os.localdomain>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* Fix storage_access not visiting else branch * fix conflict with apache#8516 in the test * update thread sync test following apache#8516 update
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Remove all attr::storage_scope usage * pyformat * fixed VTA tests * Update TIR text printer to print storage_scope on allocate * print storage scope in AllocateNode ReprPrinter * Fixed accidently removed scope tag check * remove unused function Co-authored-by: masa <masa@pop-os.localdomain>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Fix storage_access not visiting else branch * fix conflict with apache#8516 in the test * update thread sync test following apache#8516 update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final follow-up to #8366
After #8366, storage scopes associated with AttrStmt and PointerType are identical. To consolidate storage scope information into one place, I'm proposing to remove AttrStmt with
attr::storage_scopekey.With this PR, storage scope information is consolidated to
PointerType.TODO
Allocatenode