Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Unify the shared pass prefix between vm and graph #8526

Merged
merged 4 commits into from
Jul 31, 2021

Conversation

YuchenJin
Copy link
Contributor

This PR unifies the common optimization pass prefix shared between vm and graph executor into a single API.

@YuchenJin
Copy link
Contributor Author

@jroesch could you take a look?

It would be great if we can move RunDeviceAnnotationPass to Relay pass infra and the relay::transform namespace, the code would be cleaner and more passes can be packed into this prefix.

Copy link
Contributor

@jcf94 jcf94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine to me.

src/relay/backend/utils.h Outdated Show resolved Hide resolved
src/relay/backend/utils.h Outdated Show resolved Hide resolved
Copy link
Contributor

@jcf94 jcf94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me.

@tqchen tqchen merged commit 28de742 into apache:main Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants