Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix global pip cache disable change #8590

Merged
merged 1 commit into from
Aug 2, 2021
Merged

[CI] Fix global pip cache disable change #8590

merged 1 commit into from
Aug 2, 2021

Conversation

leandron
Copy link
Contributor

Fixing my mistake in #8575.

Note: I think it is important to run this command at the Dockerfile level, otherwise people that run the scripts locally on their machine might accidentally disable the cache, which for developers' workstations is useful.

cc @areusch @tqchen @Mousius for reviews

Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logically this makes sense

* The fix to disable cache needs to run after pip is installed
* This is quick follow up fix after #8575
@leandron
Copy link
Contributor Author

leandron commented Aug 2, 2021

Cc @mbaret for a review and merge if possible.

Copy link
Contributor

@mbaret mbaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@mbaret mbaret merged commit b3e832a into apache:main Aug 2, 2021
@mbaret
Copy link
Contributor

mbaret commented Aug 2, 2021

Thanks @leandron and @Mousius, this is now merged.

@leandron leandron deleted the fix_docker branch August 2, 2021 09:40
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* The fix to disable cache needs to run after pip is installed
* This is quick follow up fix after apache#8575
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* The fix to disable cache needs to run after pip is installed
* This is quick follow up fix after apache#8575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants