Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend][ONNX] Add onnx support for LessOrEqual, GreaterOrEqual #8626

Closed
wants to merge 1 commit into from
Closed

[Frontend][ONNX] Add onnx support for LessOrEqual, GreaterOrEqual #8626

wants to merge 1 commit into from

Conversation

SamKG
Copy link

@SamKG SamKG commented Aug 3, 2021 •
edited
Loading

This adds support for LessOrEqual (<=) and GreaterOrEqual (>=) ops for ONNX frontend, as introduced in opset 12.

@SamKG SamKG force-pushed the main branch 2 times, most recently from 6bd58d3 to 4c06a07 Compare August 3, 2021 00:35
mbrookhart
mbrookhart approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@SamKG
Copy link
Author

SamKG commented Aug 3, 2021

LGTM. Thanks!

thanks!
I wanted to also give adding random ops a try (#8632), but this isn't quite as simple.
Any advice on how to approach it would be appreciated.

@SamKG SamKG force-pushed the main branch 2 times, most recently from db2af02 to e09525b Compare August 3, 2021 17:36
@SamKG
Copy link
Author

SamKG commented Aug 3, 2021

Could a maintainer please re-run the workflow? I fixed a small typo in the commit

AndrewZhaoLuo
AndrewZhaoLuo reviewed Aug 30, 2021
View reviewed changes
Copy link
Contributor

@AndrewZhaoLuo AndrewZhaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, btw if you need to jostle CI you can just git commit -m 'jostle ci' --allow-empty and push.

python/tvm/relay/frontend/onnx.py
@@ -3477,6 +3493,8 @@ def _get_convert_map(opset):
"Exp": Renamer("exp"),
"Greater": Greater.get_converter(opset),
"Less": Less.get_converter(opset),
"LessOrEqual": LessOrEqual.get_converter(opset),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just use Renamer, you are just forwarding the inputs in the converter?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g. see #8967

tests/python/frontend/onnx/test_forward.py
@@ -1927,8 +1927,12 @@ def verify_binary_ops(op, x, y, out_type="float32"):
verify_binary_ops("Sum", x, z)
verify_binary_ops("Greater", x, y, "bool")
verify_binary_ops("Greater", x, z, "bool")
verify_binary_ops("GreaterOrEqual", x, y, "bool")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you uncomment the appropriate tests in unsupported_onnx_tests in this file?

@AndrewZhaoLuo
Copy link
Contributor

@SamKG do you plan to try to get this merged?

@SamKG
Copy link
Author

SamKG commented Sep 8, 2021

@SamKG do you plan to try to get this merged?

Hi Andrew,
Yes, I will try to get it merged this weekend - been a bit busy.

@areusch areusch removed their request for review September 14, 2021 15:04
@AndrewZhaoLuo
Copy link
Contributor

@SamKG do you mind if I open up an identical PR and try to merge that? Might need this in soon

@SamKG
Copy link
Author

SamKG commented Sep 20, 2021 via email

@AndrewZhaoLuo AndrewZhaoLuo mentioned this pull request Sep 21, 2021
Merged
@SamKG
Copy link
Author

SamKG commented Sep 22, 2021

Closed as #9066 handles this ( thanks @AndrewZhaoLuo )

@SamKG SamKG closed this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewZhaoLuo AndrewZhaoLuo AndrewZhaoLuo left review comments

@mbrookhart mbrookhart mbrookhart approved these changes

@comaniac comaniac Awaiting requested review from comaniac

@Huyuwei Huyuwei Awaiting requested review from Huyuwei

@jroesch jroesch Awaiting requested review from jroesch

@junrushao junrushao Awaiting requested review from junrushao

@jwfromm jwfromm Awaiting requested review from jwfromm

@kazum kazum Awaiting requested review from kazum

@merrymercy merrymercy Awaiting requested review from merrymercy

@siju-samuel siju-samuel Awaiting requested review from siju-samuel

@srkreddy1238 srkreddy1238 Awaiting requested review from srkreddy1238

@tqchen tqchen Awaiting requested review from tqchen

@yzhliu yzhliu Awaiting requested review from yzhliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamKG @AndrewZhaoLuo @mbrookhart