Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust rt link #8631

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Fix rust rt link #8631

merged 2 commits into from
Aug 5, 2021

Conversation

schell
Copy link
Contributor

@schell schell commented Aug 3, 2021

Changes by @jroesch.

Without these changes it is always required to link dynamically against libtvm.dylib, which makes it difficult to get provisioning correct (by changing rpaths, etc).

@schell schell requested a review from jroesch as a code owner August 3, 2021 02:14
@schell
Copy link
Contributor Author

schell commented Aug 4, 2021

@jroesch or @junrushao1994 can you push the button on this one?

@jroesch
Copy link
Member

jroesch commented Aug 4, 2021

Looks like CI timed out or something, kicked off another run.

@masahi masahi merged commit 5b9b16c into apache:main Aug 5, 2021
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Aug 11, 2021
* Fix support for linking to only libtvm_runtime

also ensures that the ResNet example uses the new support.

* Fix build.rs to rebuild if the Python script changes

Co-authored-by: Jared Roesch <roeschinc@gmail.com>
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* Fix support for linking to only libtvm_runtime

also ensures that the ResNet example uses the new support.

* Fix build.rs to rebuild if the Python script changes

Co-authored-by: Jared Roesch <roeschinc@gmail.com>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* Fix support for linking to only libtvm_runtime

also ensures that the ResNet example uses the new support.

* Fix build.rs to rebuild if the Python script changes

Co-authored-by: Jared Roesch <roeschinc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants