-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Runtime] Add graph_executor get_input_index API. #8633
Conversation
In graph_executor use case, user can use set_input with input index to set input parameter, but there is no straight forward way to get correct index number with input name, here provide get_input_index API to do such work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@huajsj Could you also add this to the VM api? |
@tkonolige, thanks for the comments, how about I use a separate PR to address this VM support issue? |
@huajsj Totally fine, I don't want to block this PR. It just would be nice to have the api be the same between the graph runtime and the vm. |
@tkonolige, thanks for the follow up, sure, would do that. |
* [Runtime] Add graph_executor get_input_index API. In graph_executor use case, user can use set_input with input index to set input parameter, but there is no straight forward way to get correct index number with input name, here provide get_input_index API to do such work. * Update python/tvm/contrib/graph_executor.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * Update python/tvm/contrib/graph_executor.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * Update src/runtime/graph_executor/graph_executor.cc Co-authored-by: Cody Yu <comaniac0422@gmail.com> * Update python/tvm/contrib/graph_executor.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Hi there, It seems this commit introduces bugs when tunning models on raspberry pis. When I follow the example on auto-scheduler-tune-network-arm, I got following errors
After I comment the 160th line in |
@Lyken17 Did you rebuild TVM on your raspberry pis? You can get this error when there is a TVM version mismatch between the remote and the host. |
@tkonolige I am using the tvm with commit |
* [Runtime] Add graph_executor get_input_index API. In graph_executor use case, user can use set_input with input index to set input parameter, but there is no straight forward way to get correct index number with input name, here provide get_input_index API to do such work. * Update python/tvm/contrib/graph_executor.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * Update python/tvm/contrib/graph_executor.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * Update src/runtime/graph_executor/graph_executor.cc Co-authored-by: Cody Yu <comaniac0422@gmail.com> * Update python/tvm/contrib/graph_executor.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
* [Runtime] Add graph_executor get_input_index API. In graph_executor use case, user can use set_input with input index to set input parameter, but there is no straight forward way to get correct index number with input name, here provide get_input_index API to do such work. * Update python/tvm/contrib/graph_executor.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * Update python/tvm/contrib/graph_executor.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * Update src/runtime/graph_executor/graph_executor.cc Co-authored-by: Cody Yu <comaniac0422@gmail.com> * Update python/tvm/contrib/graph_executor.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
In graph_executor use case, user can use set_input with input index to set input parameter, but there is no straight
forward way to get correct index number with input name, here provide get_input_index API to do such work.