[2/6] Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op #8795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manupak
requested review from
anijain2305,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
MarisaKirisame,
mbaret,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
trevor-m,
vinx13,
wweic,
yzhliu,
zhiics,
ZihengJiang and
a team
as code owners
8 tasks
manupak
changed the title
jroesch
removed request for
a team,
wweic,
yzhliu,
tqchen,
MarisaKirisame,
mbrookhart and
zhiics
manupak
force-pushed
the
ethosu_upstreaming_p2
branch
from
faa08d6
to
f780b9e
Compare
manupak
force-pushed
the
ethosu_upstreaming_p2
branch
from
f780b9e
to
3db968c
Compare
@jroesch You can take a look here: https://github.com/apache/tvm/pull/8806/files#diff-ba18206383e6627c682094ad5b1a211be9dd8315e82b9c5f970496ce57ebe48c (from the next PR). That's the custom Relay -> TE lowering function we're making use of which demonstrates the API. |
|
@jroesch @mbs-octoml PTAL when you have some time. |
|
LGTM thanks for the type annots, does it work if you enable checking in the mypy.ini? If so let's include that in this pr. |
|
@mbs-octoml I enabled the check in task_mypy.sh; I dont think there is nothing to change in mypy.ini as the global setting is "ignore_errors = False" |
jroesch
approved these changes
Sep 7, 2021
This commit adds mainly the relay passes and ethosu_conv2d operator to relay. The relay passes include the legalizations and preprocessing of the relay graph in the paritioning. Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>
* skipping the test if vela is not in the container. Change-Id: I68cc4259dc33e1473e460956978f364fbf6596d8
* addressing Jared's comments Change-Id: Ief669f788c6bd1a1be1004cbce5129ed06b63c3c
* addressing Elen's comments Change-Id: Iad6315bb63f12ba318deb9c5c9eff7459ff58c48
* cleanup passes Change-Id: I8e1cbedd2c4d3d0cdff481d775d9eb0577e44456
Change-Id: I7e65c2714d017c8a4b64986b111a6b51d128c963
Change-Id: I55cfbb3787c0aacdadf46c4859dff39287e65ddc
*addressing chris's comments *addressing Nicola's comments Change-Id: Id02788ddcdbc3679e0da37b2fa614cded0a4c1f5
*addressing missed 'hidden' comments of Chris *addressing one missed comment of Nicola *adding type annotations Change-Id: Iadf4907b311e195731dbbed571e95a266341db8f
*further type fixes and one missed comment Change-Id: I6da69fd95d17dfeaf5940da4f8d8c8ea142b39d2
*missed comment split_o Change-Id: I4a4b19ff2cd18e8f568a63ae827f44358ed85b8e
* adding mypy check Change-Id: Iaf58dbba2a9d8e1098a10c589d91b63c7efe646d
*removing premature insertion of get_accel_type utility Change-Id: I210512e00a5eb46adf23d1d72eb16432db526d25
* rebase fixes Change-Id: I06c9b536a7598646efce2b664fcc405aa6008203
manupak
force-pushed
the
ethosu_upstreaming_p2
branch
from
80a2c43
to
ed68938
Compare
|
@Mousius @ashutosh-arm , shall we prioritize to land this next as it is approved ? it is getting conflicts from CMSISNN PRs. |
|
Yes, of course. |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op This commit adds mainly the relay passes and ethosu_conv2d operator to relay. The relay passes include the legalizations and preprocessing of the relay graph in the paritioning. Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * skipping the test if vela is not in the container. Change-Id: I68cc4259dc33e1473e460956978f364fbf6596d8 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * addressing Jared's comments Change-Id: Ief669f788c6bd1a1be1004cbce5129ed06b63c3c * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * addressing Elen's comments Change-Id: Iad6315bb63f12ba318deb9c5c9eff7459ff58c48 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * cleanup passes Change-Id: I8e1cbedd2c4d3d0cdff481d775d9eb0577e44456 * Update TE comments Change-Id: I7e65c2714d017c8a4b64986b111a6b51d128c963 * Address ekalda's comments in TE Change-Id: I55cfbb3787c0aacdadf46c4859dff39287e65ddc * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *addressing chris's comments *addressing Nicola's comments Change-Id: Id02788ddcdbc3679e0da37b2fa614cded0a4c1f5 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *addressing missed 'hidden' comments of Chris *addressing one missed comment of Nicola *adding type annotations Change-Id: Iadf4907b311e195731dbbed571e95a266341db8f * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *further type fixes and one missed comment Change-Id: I6da69fd95d17dfeaf5940da4f8d8c8ea142b39d2 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *missed comment split_o Change-Id: I4a4b19ff2cd18e8f568a63ae827f44358ed85b8e * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * adding mypy check Change-Id: Iaf58dbba2a9d8e1098a10c589d91b63c7efe646d * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *removing premature insertion of get_accel_type utility Change-Id: I210512e00a5eb46adf23d1d72eb16432db526d25 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * rebase fixes Change-Id: I06c9b536a7598646efce2b664fcc405aa6008203 Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op This commit adds mainly the relay passes and ethosu_conv2d operator to relay. The relay passes include the legalizations and preprocessing of the relay graph in the paritioning. Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * skipping the test if vela is not in the container. Change-Id: I68cc4259dc33e1473e460956978f364fbf6596d8 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * addressing Jared's comments Change-Id: Ief669f788c6bd1a1be1004cbce5129ed06b63c3c * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * addressing Elen's comments Change-Id: Iad6315bb63f12ba318deb9c5c9eff7459ff58c48 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * cleanup passes Change-Id: I8e1cbedd2c4d3d0cdff481d775d9eb0577e44456 * Update TE comments Change-Id: I7e65c2714d017c8a4b64986b111a6b51d128c963 * Address ekalda's comments in TE Change-Id: I55cfbb3787c0aacdadf46c4859dff39287e65ddc * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *addressing chris's comments *addressing Nicola's comments Change-Id: Id02788ddcdbc3679e0da37b2fa614cded0a4c1f5 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *addressing missed 'hidden' comments of Chris *addressing one missed comment of Nicola *adding type annotations Change-Id: Iadf4907b311e195731dbbed571e95a266341db8f * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *further type fixes and one missed comment Change-Id: I6da69fd95d17dfeaf5940da4f8d8c8ea142b39d2 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *missed comment split_o Change-Id: I4a4b19ff2cd18e8f568a63ae827f44358ed85b8e * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * adding mypy check Change-Id: Iaf58dbba2a9d8e1098a10c589d91b63c7efe646d * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *removing premature insertion of get_accel_type utility Change-Id: I210512e00a5eb46adf23d1d72eb16432db526d25 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * rebase fixes Change-Id: I06c9b536a7598646efce2b664fcc405aa6008203 Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds mainly the relay passes and ethosu_conv2d
operator to relay. The relay passes include the legalizations
and preprocessing of the relay graph in the paritioning.
Co-authored-by: Matthew Barrett matthew.barrett@arm.com