[ONNX] Add Einsum converter #8985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anwang2009
requested review from
anijain2305,
areusch,
comaniac,
Huyuwei,
jcf94,
jroesch,
junrushao,
jwfromm,
kazum,
kevinthesun,
Laurawly,
MarisaKirisame,
masahi,
mbrookhart,
merrymercy,
siju-samuel,
slyubomirsky,
srkreddy1238,
tqchen,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
|
This is really nice! CC @ZihengJiang @hzfan |
masahi
reviewed
Sep 11, 2021
masahi
reviewed
Sep 11, 2021
masahi
reviewed
Sep 11, 2021
mbrookhart
approved these changes
Sep 13, 2021
masahi
reviewed
Sep 15, 2021
| """einsum cuda strategy""" | ||
| strategy = _op.OpStrategy() | ||
| # TODO: Add cuda-specific op implementation for einsum | ||
| strategy.add_implementation( |
There was a problem hiding this comment.
This would lead to an error if you try to run it on cuda right? It is better to remove this strategy until we have a CUDA schedule ready. The error message would be clearer than the one from incorrect scheduling.
There was a problem hiding this comment.
The test_onnx_nodes tests run on CUDA and have passed. I will remove if you think it's necessary to remove despite that?
There was a problem hiding this comment.
Oh interesting. I didn't know that topi.generic.schedule_extern somehow generates a valid schedule.
masahi
approved these changes
Sep 15, 2021
AndrewZhaoLuo
added a commit
to AndrewZhaoLuo/tvm
that referenced
this pull request
Sep 16, 2021
* main: (102 commits) Implementation of relay_to_tir target hook (apache#8423) [Onnx] Fix NLL Loss tests (apache#8971) [Bugfix] Fix other div zero errors also in rewrite_simplify (apache#8983) [ONNX] enable the onnx tests after PR apache#8274 merged (apache#9019) [Hexagon] Disable `thread_local` on Hexagon (apache#9025) [Hexagon] Allow undefined symbols in libtvm_runtime.so on Hexagon (apache#9024) [Onnx] Add momentum (apache#9000) fix (apache#9021) [Community] @AndrewZhaoLuo -> Reviewer (apache#9020) [Hexagon] Implement model launcher (apache#8986) [Relay][Pass] Add ExtractOperators pass (apache#8996) [BYOC][TensorRT] Add TensorRT own int8 calibration support to TensorRT BYOC integration (apache#8808) [ONNX] Add Einsum converter (apache#8985) Add standalone_crt/ to be part of the wheel package, when available. (apache#9005) [Relay] Remove memory planing from LowerTEPass (apache#8974) [Hexagon] Treat floats as float32 when passing args to offloaded kernels (apache#9010) [Runtime] Pipeline Executor Initial patch. (apache#8702) [Hexagon] `llvm-options` attribute is an array of strings (apache#9011) disable cuda int8 schedule for non-cuda gpu target (apache#9014) [Torch] Add an option to make imported models compatible with the Relay text parser (apache#9015) ...
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* einsum * address review * move files around * use generic topi op * TODO comment * jostle ci * jostle ci
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* einsum * address review * move files around * use generic topi op * TODO comment * jostle ci * jostle ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title
cc @mbrookhart @AndrewZhaoLuo
thanks @AndrewZhaoLuo for maintaining https://tvm.apache.org/docs/dev/relay_add_op.html, this doc was super helpful!