Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] [Relay] Dynamic squeeze #9095

Merged
merged 11 commits into from
Sep 28, 2021
Merged

Conversation

CircleSpin
Copy link
Contributor

Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a couple of formatting/lint issues, and there's one print still in here, but otherwise LGTM

python/tvm/relay/frontend/onnx.py Outdated Show resolved Hide resolved
Copy link
Contributor

@AndrewZhaoLuo AndrewZhaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly. A few comments

python/tvm/relay/frontend/onnx.py Outdated Show resolved Hide resolved
python/tvm/relay/op/dyn/_transform.py Outdated Show resolved Hide resolved
src/relay/op/dyn/tensor/transform.cc Show resolved Hide resolved
src/relay/op/dyn/tensor/transform.cc Outdated Show resolved Hide resolved
src/relay/op/dyn/tensor/transform.cc Outdated Show resolved Hide resolved
src/relay/op/dyn/tensor/transform.cc Outdated Show resolved Hide resolved
src/relay/op/dyn/tensor/transform.cc Outdated Show resolved Hide resolved
tests/python/relay/dyn/test_dynamic_op_level3.py Outdated Show resolved Hide resolved
@AndrewZhaoLuo
Copy link
Contributor

Please also change the title of this PR to something like "[ONNX] [Relay] Dynamic Squeeze"

@CircleSpin CircleSpin changed the title Dynamic squeeze [ONNX] [Relay] Dynamic squeeze Sep 23, 2021
Copy link
Contributor

@AndrewZhaoLuo AndrewZhaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM

@mbrookhart mbrookhart merged commit 5e46e75 into apache:main Sep 28, 2021
AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Sep 28, 2021
* main: (37 commits)
  [ONNX] [Relay] Dynamic squeeze (apache#9095)
  [Meta Schedule][M3b] Database (apache#9061)
  [Bugfix] Add nullptr checking for `AttrStmt` with `coproc_uop_scope` attr key (apache#9123)
  [Codegen] Swap out analyzer when outlining (apache#9117)
  [CI] bash.sh, build.sh: add option to set the container name and hostname (apache#9110)
  Ensure google-mock is installed and setup (apache#9107)
  Arm(R) Ethos(TM)-U NPU TIR to CS for Conv2D (apache#8811)
  Frontend: add onnx GlobalLpPool op (apache#8845)
  [LLVM] Refactor MakeCallPacked, NFC (apache#9118)
  prevent casting handle to other types (apache#9114)
  fix annotation of tir generic (apache#9119)
  [Relay] Register layout conversion function to more reduce ops (apache#9048)
  Fix the missing `dtype` attribute of `tir.Shuffle` in Python level (apache#9131)
  add `multiply` and remove `subtract` for dnnl json runtime (apache#9120)
  relu of dnnl json runtime only support 4-dims input (apache#9122)
  [Meta Schedule][M3a] SpaceGenerator  (apache#9079)
  [TensorIR][Bugfix] Disallow fusing loops with dependency (apache#9112)
  adding Jorn to reviewers list (apache#9105)
  [BYOC] Fix incorrect conv2d padding handling of `dnnl with c source runtime` (apache#9097)
  [Frontend][TFLite] fix apache#9078 (apache#9099)
  ...
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* adding dynamic squeeze first steps

* Matt B. implementing shape

* squeeze implemented, dynamic_to_static and onnx importer next

* add Squeeze op convert to onnx.py

* dynamic to static

* removed comments

* removed comments

* added comment

* adjusted comment

* black and lint

* ran make format in root directory

Co-authored-by: CircleSpin <jocelyn@pop-os.localdomain>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* adding dynamic squeeze first steps

* Matt B. implementing shape

* squeeze implemented, dynamic_to_static and onnx importer next

* add Squeeze op convert to onnx.py

* dynamic to static

* removed comments

* removed comments

* added comment

* adjusted comment

* black and lint

* ran make format in root directory

Co-authored-by: CircleSpin <jocelyn@pop-os.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants