[Runtime] Pipeline Executor Second patch, configuration load and executor export/import. #9108
Conversation
huajsj
requested review from
areusch,
comaniac,
jroesch,
junrushao,
kazum,
liangfu,
masahi,
merrymercy,
tmoreau89,
tqchen,
vinx13,
yzhliu,
zhiics and
ZihengJiang
as code owners
|
Probably don't have many bandwidths this week to review this PR but I'll try. |
|
I'll take a look tomorrow. |
There was a problem hiding this comment.
Did the first pass, still too many basic grammar errors that distract me from focusing on technical details.
I don't want to correct all of them, so please go through ALL of your change again:
- Fix as many grammar mistake as possible. Things like the lack of
a,theorsfor plural, third person pronoun (this function return->this function returns). - Variable names should be snake_case
- You use the term
configureas if it was a noun. Replace all of them withconfig.
There was a problem hiding this comment.
There are still many grammar and other minor errors. Please go through them again. Correcting only the ones I pointed out is not sufficient.
Remove all _configure names as I said in the previous review.
In many places you use an index subtracted by 1, like string_config[mod_idx - 1] = mconf. I don't like them. Please restructure your code so that such weird indexing is unnecessary.
| reader->Read(&input_name); | ||
| } | ||
| } | ||
| ICHECK(mod_idx >= 0); |
There was a problem hiding this comment.
So this mod_idx can be zero while others are > 0? I think it is confusing.
There was a problem hiding this comment.
in module config file, there are 2 place have mod_idx information , first is the module list with output, here all module is graphexecutor module, and no PipelineExecutor or global module here, the second place is the binding place that use to describe which output binding with which module input/output, here the module can be graphexecutor module or PipelineExecutor/global module, because we need import data or output data for PipelineExecutor, that is the reason why in different place there are difference check logic.
added related comments for the said logic explain.
|
@huajsj Why |
| '"load_config" or "pipeline_config" is missing in %s' % config_file_name | ||
| ) | ||
|
|
||
| # The config file use to load library, prameters, and JSON files. |
…utor export/import. (apache#9108) * [pipeline executor] Add configuration load function and pipeline executor export,import function. * address review comments. * polish comments and doc string. * address review comments. * address review comments. * Change mod_idx start from 0, remove mod_idx - 1 logic. * address review comments. * polish documents. * adress review comments * address review comments. * address review comments. * polish the document. * address review comments. * address review comments. * polish comments. * Triger build. * address review comments. * address review comments. * fix grammar issue. * polish documents. * add single global binding check. * address review comments. * trigger build.
…utor export/import. (apache#9108) * [pipeline executor] Add configuration load function and pipeline executor export,import function. * address review comments. * polish comments and doc string. * address review comments. * address review comments. * Change mod_idx start from 0, remove mod_idx - 1 logic. * address review comments. * polish documents. * adress review comments * address review comments. * address review comments. * polish the document. * address review comments. * address review comments. * polish comments. * Triger build. * address review comments. * address review comments. * fix grammar issue. * polish documents. * add single global binding check. * address review comments. * trigger build.
…utor export/import. (apache#9108) * [pipeline executor] Add configuration load function and pipeline executor export,import function. * address review comments. * polish comments and doc string. * address review comments. * address review comments. * Change mod_idx start from 0, remove mod_idx - 1 logic. * address review comments. * polish documents. * adress review comments * address review comments. * address review comments. * polish the document. * address review comments. * address review comments. * polish comments. * Triger build. * address review comments. * address review comments. * fix grammar issue. * polish documents. * add single global binding check. * address review comments. * trigger build.
This patch is one of serial patch for PR 7892 splitting. this is second part the pipeline executor, include the configuration JSON file load and pipeline executor export and import.