Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetaSchedule][M4a] Local runner #9153

Merged
merged 8 commits into from
Oct 1, 2021

Conversation

shingjan
Copy link
Contributor

@shingjan shingjan commented Sep 29, 2021

This PR is part of the meta schedule project (#8473) that adds the reference
implementation of LocalRunner with PopenPool executor and a follow-up PR of #9111 .

@vinx13 @junrushao1994 @zxybazh

@shingjan
Copy link
Contributor Author

One RPCRunner test is failing and I will rebase after the fix (#9150) gets in.

@junrushao junrushao changed the title [Meta Schedule][M3a]Local runner [Meta Schedule][M4a] Local runner Sep 29, 2021
@junrushao
Copy link
Member

Thanks @shingjan for the PR. It's overall in good shape, and I left only one comment on potential duplication

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mostly nits.

python/tvm/meta_schedule/runner/local_runner.py Outdated Show resolved Hide resolved
@junrushao
Copy link
Member

@shingjan would you like to act accordingly to the final nitpicks so that we could get it merged soon? Thanks!

@junrushao
Copy link
Member

Thanks @shingjan! I believe the PR is in good shape

@junrushao
Copy link
Member

Thanks @shingjan! I'm rerunning the GitHub Action jobs due to flakiness

@junrushao
Copy link
Member

junrushao commented Oct 1, 2021

@shingjan would you mind rebasing to the latest main given the flakiness has been fixed by commit df24393

Yuanjing Shi and others added 6 commits October 1, 2021 11:10
* localrunner

* localrunner init

* linting

* address comments

* exception handling

* single run testcase

* two more cases added

* add exception case

* one case with AddModule added

* address comments

* address comments

* remove unused dependency

* optional arguments
@shingjan shingjan force-pushed the feature/20210929/local_runner branch from 9c2b8a4 to 9f293d5 Compare October 1, 2021 18:10
@vinx13 vinx13 merged commit 574a47c into apache:main Oct 1, 2021
@vinx13
Copy link
Member

vinx13 commented Oct 1, 2021

Thanks @shingjan @junrushao1994 @comaniac this is merged

ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
* [Meta Schedule][M3a]Local runner (apache#479)

* localrunner

* localrunner init

* linting

* address comments

* exception handling

* single run testcase

* two more cases added

* add exception case

* one case with AddModule added

* address comments

* address comments

* remove unused dependency

* optional arguments

* linting

* add utils

* linting

* address comments

* remove non-ascii commennt

* add sanity check

* address comments
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* [Meta Schedule][M3a]Local runner (apache#479)

* localrunner

* localrunner init

* linting

* address comments

* exception handling

* single run testcase

* two more cases added

* add exception case

* one case with AddModule added

* address comments

* address comments

* remove unused dependency

* optional arguments

* linting

* add utils

* linting

* address comments

* remove non-ascii commennt

* add sanity check

* address comments
@junrushao junrushao changed the title [Meta Schedule][M4a] Local runner [MetaSchedule][M4a] Local runner Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants