-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MetaSchedule][M4a] Local runner #9153
Conversation
One |
Thanks @shingjan for the PR. It's overall in good shape, and I left only one comment on potential duplication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Mostly nits.
@shingjan would you like to act accordingly to the final nitpicks so that we could get it merged soon? Thanks! |
59e5a19
to
a504955
Compare
Thanks @shingjan! I believe the PR is in good shape |
Thanks @shingjan! I'm rerunning the GitHub Action jobs due to flakiness |
* localrunner * localrunner init * linting * address comments * exception handling * single run testcase * two more cases added * add exception case * one case with AddModule added * address comments * address comments * remove unused dependency * optional arguments
9c2b8a4
to
9f293d5
Compare
Thanks @shingjan @junrushao1994 @comaniac this is merged |
* [Meta Schedule][M3a]Local runner (apache#479) * localrunner * localrunner init * linting * address comments * exception handling * single run testcase * two more cases added * add exception case * one case with AddModule added * address comments * address comments * remove unused dependency * optional arguments * linting * add utils * linting * address comments * remove non-ascii commennt * add sanity check * address comments
* [Meta Schedule][M3a]Local runner (apache#479) * localrunner * localrunner init * linting * address comments * exception handling * single run testcase * two more cases added * add exception case * one case with AddModule added * address comments * address comments * remove unused dependency * optional arguments * linting * add utils * linting * address comments * remove non-ascii commennt * add sanity check * address comments
This PR is part of the meta schedule project (#8473) that adds the reference
implementation of LocalRunner with PopenPool executor and a follow-up PR of #9111 .
@vinx13 @junrushao1994 @zxybazh