Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSIS-NN] Initial operator support for Mul #9163

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

Mousius
Copy link
Member

@Mousius Mousius commented Sep 30, 2021

This is largely as it says on the tin, it adds Mul support to CMSIS-NN

Copy link
Contributor

@ashutosh-arm ashutosh-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris. LGTM!

Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly looks good : one nit and a question.

Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. btw, do we have a tracking issue for note down follow ups ?

@Mousius
Copy link
Member Author

Mousius commented Sep 30, 2021

@manupa-arm no need, just did it: #9167

This is largely as it says on the tin, it adds Mul support to CMSIS-NN
@manupak manupak self-assigned this Oct 1, 2021
Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mousius!. Lets keep it open for few hours for other timezones and then proceed to merge, as it quite similar to how other operators are added.

@manupak manupak merged commit 6d120c0 into apache:main Oct 1, 2021
@manupak
Copy link
Contributor

manupak commented Oct 1, 2021

Thanks @Mousius @ashutoshparkhi.

from tvm import relay


def skip_if_no_reference_system(func):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we improve this a bit and make it less brittle? it seems like if we ever use this from a different test (e.g. TOPI tests run on GPU) we may need to broaden it a bit. i'm not sure Corstone300 provides a good way to detect it from TVM--but perhaps you guys know better? we could just add a pytest mark and flag --enable-corstone300-tests and add the flag to the relevant tests/scripts/task_*.sh file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
This is largely as it says on the tin, it adds Mul support to CMSIS-NN
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
This is largely as it says on the tin, it adds Mul support to CMSIS-NN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants