-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMSIS-NN] Initial operator support for Mul #9163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Chris. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly looks good : one nit and a question.
cf54890
to
762d7e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. btw, do we have a tracking issue for note down follow ups ?
@manupa-arm no need, just did it: #9167 |
This is largely as it says on the tin, it adds Mul support to CMSIS-NN
762d7e8
to
ab20bbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mousius!. Lets keep it open for few hours for other timezones and then proceed to merge, as it quite similar to how other operators are added.
Thanks @Mousius @ashutoshparkhi. |
from tvm import relay | ||
|
||
|
||
def skip_if_no_reference_system(func): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we improve this a bit and make it less brittle? it seems like if we ever use this from a different test (e.g. TOPI tests run on GPU) we may need to broaden it a bit. i'm not sure Corstone300 provides a good way to detect it from TVM--but perhaps you guys know better? we could just add a pytest mark and flag --enable-corstone300-tests
and add the flag to the relevant tests/scripts/task_*.sh file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @manupa-arm
This is largely as it says on the tin, it adds Mul support to CMSIS-NN
This is largely as it says on the tin, it adds Mul support to CMSIS-NN
This is largely as it says on the tin, it adds Mul support to CMSIS-NN