-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hexagon] Add hexagon launcher to apps and add to TVM's build system #9220
Conversation
hexagon launcher along with a standard TVM build.
instructions on how to build the launcher alongside TVM.
structure and group common code into cmake/HexagonLauncher.cmake.
This is great! I just started testing it, and the first thing I saw was a bunch of warnings from the Android NDK cmake:
I'm using cmake 3.17, the NDK bundle version in my SDK is 22.1.7171670. These warning are most likely safe to ignore, but maybe there could be a note about it somewhere? Your call, I'm fine either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…pache#9220) * Add USE_HEXAGON_LAUNCHER cmake configuration to build the android hexagon launcher along with a standard TVM build. * Update hexagon launcher README.md to include instructions on how to build the launcher alongside TVM. * Move Hexagon launcher into top-level apps directory. * Refactor hexagon launcher cmake directory structure and group common code into cmake/HexagonLauncher.cmake. * Address CRs from @kparzysz-quic.
…pache#9220) * Add USE_HEXAGON_LAUNCHER cmake configuration to build the android hexagon launcher along with a standard TVM build. * Update hexagon launcher README.md to include instructions on how to build the launcher alongside TVM. * Move Hexagon launcher into top-level apps directory. * Refactor hexagon launcher cmake directory structure and group common code into cmake/HexagonLauncher.cmake. * Address CRs from @kparzysz-quic.
…pache#9220) * Add USE_HEXAGON_LAUNCHER cmake configuration to build the android hexagon launcher along with a standard TVM build. * Update hexagon launcher README.md to include instructions on how to build the launcher alongside TVM. * Move Hexagon launcher into top-level apps directory. * Refactor hexagon launcher cmake directory structure and group common code into cmake/HexagonLauncher.cmake. * Address CRs from @kparzysz-quic.
Goal: Simplify the build system for running models on hexagon.
This PR moves the hexagon launcher to be a tvm application (in tvm/apps). It also introduces the
USE_HEXAGON_LAUNCHER
build flag to build the launcher and all dependencies alongside a standard TVM build which consolidates the number of manual build steps from five to one.Also added a section on Compilation with TVM to the launcher readme.