[TIR] Add support for 0-dim buffer #9224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shingjan
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
shingjan
changed the title
shingjan
requested review from
Hzfengsy,
kparzysz-quic,
masahi,
vinx13 and
ZihengJiang
as code owners
vinx13
reviewed
Oct 12, 2021
|
given we have 0-rank support in TIR, we can remove these lines to directly lower to 0-rank TIR https://github.com/apache/tvm/blob/main/src/te/operation/create_primfunc.cc#L105-L109. Please check if we can pass this test case https://github.com/apache/tvm/blob/main/tests/python/unittest/test_te_create_primfunc.py#L286-L300 |
vinx13
reviewed
Oct 12, 2021
vinx13
reviewed
Oct 12, 2021
zxybazh
approved these changes
Oct 12, 2021
|
Overall LGTM, please address comments and get it merged soon |
|
@vinx13 With https://github.com/apache/tvm/blob/main/src/te/operation/create_primfunc.cc#L105-L109 removed, all tests under |
added 8 commits
October 13, 2021 11:17
shingjan
changed the title
vinx13
approved these changes
Oct 13, 2021
vinx13
reviewed
Oct 14, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to add support and test cases for 0-dimensional buffer in TVM.
cc: @junrushao1994 @vinx13 @zxybazh