Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keras] Add l2_normalize support #9383

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

apivovarov
Copy link
Contributor

@apivovarov apivovarov commented Oct 28, 2021

This PR adds support for Lambda(l2_normalize).
Keras does not have dedicated Layer for l2_normalize. Typical solution for that is to wrap K.l2_normalize with Lambda layer and add it to the model.

@apivovarov
Copy link
Contributor Author

@AndrewZhaoLuo Could you review this PR?

@AndrewZhaoLuo
Copy link
Contributor

I will review this either today or tomorrow

Copy link
Contributor

@AndrewZhaoLuo AndrewZhaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @masahi ?

.gitignore Show resolved Hide resolved
@masahi masahi merged commit bff9884 into apache:main Nov 3, 2021
@apivovarov apivovarov deleted the keras_l2_norm4 branch November 3, 2021 18:55
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants