[microNPU][3] Plan generation for the cascader #9890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
jacobbohlin
force-pushed
the
ethosu-cascader-6
branch
2 times, most recently
from
f320c4a to
522764b
Compare
mbaret
force-pushed
the
ethosu-cascader-6
branch
from
522764b to
9b66ba0
Compare
jacobbohlin
force-pushed
the
ethosu-cascader-6
branch
from
9b66ba0 to
2752396
Compare
mbaret
force-pushed
the
ethosu-cascader-6
branch
from
2752396 to
59dd0ec
Compare
mbaret
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen,
yzhliu and
zhiics
as code owners
manupak
reviewed
Jan 27, 2022
There was a problem hiding this comment.
Broadly looks good!.
I noticed that we dont have docstrings for some python functions/classes/objects that calls into C++ version that is well documented. However, it feels better to write a short summary there and with a forward pointer to detailed description.
mbaret
force-pushed
the
ethosu-cascader-6
branch
from
59dd0ec to
91e522b
Compare
|
I've added docs to all the functions/classes that are meant to be used/access via Python, and marked those functions which are used only for testing as private. |
manupak
approved these changes
Feb 2, 2022
The cascader creates 'Plans' which describe how to schedule subgraphs. As part of the cascading algorithm, it's necessary to explore a large variety of Plans which are Pareto optimal (in terms of memory usage and performance). This is done by the Plan generation algorithm. This commit adds the TensorConfig and Plan data structures which hold information on how to schedule the tensors/operators. Additionally, it includes functions to calculate Pareto frontiers which are used to cull sub-optimal Plans. Change-Id: Ia358b2a1b29bd810df4441027752ced75812ad4e
Change-Id: If4e083a3c96af75a8ffa72510704818d21a477d9
Change-Id: I831137f8235665bc20ab4c060cc7049ffd48088a
Change-Id: Ifbe97eb33b1ef313710f24c687a8155421a3c195
mbaret
force-pushed
the
ethosu-cascader-6
branch
from
91e522b to
1a0df5c
Compare
|
Thanks @mbaret . This is merged now! |
mbs-octoml
pushed a commit
to mbs-octoml/mbs-tvm
that referenced
this pull request
Feb 5, 2022
* [microNPU][3] Plan generation for the cascader The cascader creates 'Plans' which describe how to schedule subgraphs. As part of the cascading algorithm, it's necessary to explore a large variety of Plans which are Pareto optimal (in terms of memory usage and performance). This is done by the Plan generation algorithm. This commit adds the TensorConfig and Plan data structures which hold information on how to schedule the tensors/operators. Additionally, it includes functions to calculate Pareto frontiers which are used to cull sub-optimal Plans. Change-Id: Ia358b2a1b29bd810df4441027752ced75812ad4e * Fixes to lint/test Change-Id: If4e083a3c96af75a8ffa72510704818d21a477d9 * Improve python docs Change-Id: I831137f8235665bc20ab4c060cc7049ffd48088a * Fix enum hashing issue with old gcc Change-Id: Ifbe97eb33b1ef313710f24c687a8155421a3c195
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* [microNPU][3] Plan generation for the cascader The cascader creates 'Plans' which describe how to schedule subgraphs. As part of the cascading algorithm, it's necessary to explore a large variety of Plans which are Pareto optimal (in terms of memory usage and performance). This is done by the Plan generation algorithm. This commit adds the TensorConfig and Plan data structures which hold information on how to schedule the tensors/operators. Additionally, it includes functions to calculate Pareto frontiers which are used to cull sub-optimal Plans. Change-Id: Ia358b2a1b29bd810df4441027752ced75812ad4e * Fixes to lint/test Change-Id: If4e083a3c96af75a8ffa72510704818d21a477d9 * Improve python docs Change-Id: I831137f8235665bc20ab4c060cc7049ffd48088a * Fix enum hashing issue with old gcc Change-Id: Ifbe97eb33b1ef313710f24c687a8155421a3c195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: apache/tvm-rfcs#37
Issue: #9429
The cascader creates 'Plans' which describe how to schedule subgraphs. As part of the cascading algorithm, it's necessary to explore a large variety of Plans which are Pareto optimal (in terms of memory usage and performance). This is done by the Plan generation algorithm.
This commit adds the TensorConfig and Plan data structures which hold information on how to schedule the tensors/operators. Additionally, it includes functions to calculate Pareto frontiers which are used to cull sub-optimal Plans.