Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add action to label mergeable PRs #9931

Closed
wants to merge 1 commit into from
Closed

Add action to label mergeable PRs #9931

wants to merge 1 commit into from

Conversation

driazati
Copy link
Member

@driazati driazati commented Jan 13, 2022 •
edited
Loading

Developers often have to ping a committer once their PRs are both passing in CI and are approved. This helps facilitate this process by marking such PRs with a label ready-for-merge so committers can easily filter for outstanding PRs that need attention.

Tested in driazati#2 via https://github.com/driazati/tvm/actions/workflows/ready_for_merge.yml

@jroesch
Copy link
Member

jroesch commented Jan 14, 2022

This looks great to me, lmk when this is "ready for merge review" 😆

@driazati driazati marked this pull request as ready for review January 14, 2022 21:44
@driazati driazati force-pushed the gha_merge branch 2 times, most recently from ddfec0f to f87c1a0 Compare January 14, 2022 22:08
@driazati driazati mentioned this pull request Jan 14, 2022
Merged
areusch
areusch approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[DO NOT MERGE] approving to trigger the workflow

areusch
areusch requested changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clicked wrong button

@driazati
Copy link
Member Author

driazati commented Jan 15, 2022 •
edited
Loading

Reverting back to draft since I'm not sure this is workable since when GitHub reports a status (i.e. when Jenkins is done) I don't see any way to get the original pull request when the PR comes from a forked repo, so the main use case (approval happens, then Jenkins completes hours later) doesn't work. We might just need to push this out of GHA to run at the end of Jenkins once everything is complete for status events this was annoying to implement so I re-worked it to run as a cron (there might be a delay in when the label gets added but it shouldn't be too bad at ~15 min)

@driazati driazati marked this pull request as draft January 15, 2022 00:30
@driazati driazati force-pushed the gha_merge branch 3 times, most recently from 8289e4f to ea2665a Compare January 21, 2022 22:32
@driazati driazati marked this pull request as ready for review January 21, 2022 22:34
@driazati driazati requested a review from areusch January 21, 2022 22:34
@driazati driazati force-pushed the gha_merge branch 3 times, most recently from ba0a195 to b9886e7 Compare January 26, 2022 01:11
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

It has been a while since this PR was updated, @areusch please leave a review or address the outstanding comments

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

It has been a while since this PR was updated, @areusch please leave a review or address the outstanding comments

@driazati
Copy link
Member Author

driazati commented Mar 1, 2022

closing this to keep it from languishing anymore, an RFC will be coming soon that should address the underlying issue of merging PRs

@driazati driazati closed this Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comaniac comaniac Awaiting requested review from comaniac

@icemelon icemelon Awaiting requested review from icemelon

@jroesch jroesch Awaiting requested review from jroesch

@junrushao junrushao Awaiting requested review from junrushao

@merrymercy merrymercy Awaiting requested review from merrymercy

@tqchen tqchen Awaiting requested review from tqchen

@yzhliu yzhliu Awaiting requested review from yzhliu

@areusch areusch Awaiting requested review from areusch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driazati @jroesch @areusch