-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BYOC-DNNL] add support for more ops and fusion patterns #9995
Conversation
CC @apeskov and @mbs-octoml |
Hi, @apeskov and @mbs-octoml. Could you please take some time to review this PR? Look forward to your comments. |
@mikepapadim can you take a look at a this one, thanks. |
I ll take a look! |
Hi @mikepapadim, do you have any comments? |
@tmoreau89 @mbs-octoml @mikepapadim @masahi Could you please help me review this PR? |
I can merge this after you pass CI. |
|
Hi @masahi , I wonder which version of OneDNN is used for CI. |
tvm/docker/install/ubuntu_install_dnnl.sh Line 24 in 8131364
Probably too old, we should update that first. |
I will try to update to |
Note that changing the docker script won't immediately update the CI environment (so the build will fail again).You need to send that change separately first like #10179. I can take care of actually updating the ci image. |
Do I need to submit an RFC, or just submit an independent PR? |
No need for another rfc. |
The latest oneDNN release is v2.5.2 |
Yes, the latest release version is v2.5.2, but only v2.2 has dnnl_lnx_2.2.0_cpu_gomp.tgz |
@crazydemo, right, we stopped publishing binary releases on Github after v2.2. Binaries for later versions are available on conda-forge. |
@vpirogov Thank you so much! I will update the CI to the latest version. |
hi @masahi , how can I restart the ci check? |
So this is how it works.
CI update is an involved process. So please wait until at least tomorrow. |
Got it! Thank you for all your help and explanation! |
@crazydemo it's ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except one minor nit. Can be addressed in a later PR if more is coming.
@crazydemo please look at the CI issues. |
Enabled OP List: