-
Notifications
You must be signed in to change notification settings - Fork 168
Labels
good first issueGood for newcomersGood for newcomers
Description
Code of Conduct
- I agree to follow this project's Code of Conduct
Search before asking
- I have searched in the issues and found no similar issues.
Describe the feature
@Override
public void unregisterShuffle(String appId) {
if (appId == null) {
return;
}
Map<Integer, Set<ShuffleServerInfo>> appServerMap = shuffleServerInfoMap.get(appId);
if (appServerMap == null) {
return;
}
appServerMap.keySet().forEach(shuffleId -> unregisterShuffle(appId, shuffleId));
}
Motivation
I found the unregister app in shuffleManager stop method always is timeout when having too much stages. And there is no need to unregister shuffle one by one, why not introducing unregister app rpc method?
But I'm hesitant whether to reuse the unregisterShuffle rpc by making the shuffleId of protobuf optional to achieve the app purging
Describe the solution
No response
Additional context
No response
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers