-
Notifications
You must be signed in to change notification settings - Fork 170
Description
Code of Conduct
- I agree to follow this project's Code of Conduct
Search before asking
- I have searched in the issues and found no similar issues.
What would you like to be improved?
Spark have multiple serializers. We support the spark serializer which supportsRelocationOfSerializedObjects.
You can see https://github.com/apache/spark/blob/25849684b78cca6651e25d6efc9644a576e7e20f/core/src/main/scala/org/apache/spark/serializer/Serializer.scala#L98
Spark have three kinds of serializer
org.apache.spark.serializer.JavaSerializer
org.apache.spark.sql.execution.UnsafeRowSerializer
org.apache.spark.serializer.KryoSerializer
Only org.apache.spark.serializer.JavaSerializer don't support RelocationOfSerializedObjects.
So when we find the parameters to use org.apache.spark.serializer.JavaSerializer, We should throw an exception, similar code that you can refer to https://github.com/apache/incubator-uniffle/blob/d09b40b90b8db613dbd346e0cd91f70f3950b430/client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java#L141
How should we improve?
check Serializer whether support supportsRelocationOfSerializedObjects, if not, throw an exception.
Are you willing to submit PR?
- Yes I am willing to submit a PR!