-
Notifications
You must be signed in to change notification settings - Fork 170
Open
Description
Code of Conduct
- I agree to follow this project's Code of Conduct
Search before asking
- I have searched in the issues and found no similar issues.
Describe the feature
Introduce the general client conf for mr/spark
- Introduce the class of
RssClientConfto set the general configOptions for mr/spark - Introduce the class of
RssSparkClientConfto set the spark exclusiveconfigOptionsand to construct the RssConf from theSparkConf - Introduce the class of
RssMRClientConf
I proposed a PR #200 before, but it looks this part needs to do much changes.
Motivation
Now in mr/spark client conf, we don't obey the rule of uniffle configOptions. It causes the some problems as follows
- When introducing the client general conf, we have to write three times in
RssSparkConfig/RssClientConfig/RssMRConfig. Actually there is no need to leave dirty works for developers. - If when introducing a general method for MR/Spark and need to some configs from Rss client conf. In current implementation, we have to introduce extra class for method's params. If we having the general RssClientConf, it will benifit more.
Describe the solution
No response
Additional context
No response
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Metadata
Metadata
Assignees
Labels
No labels