[#434] refactor: New utility method to cover dynamic class loading in RSSUtils#1104
Merged
roryqi merged 1 commit intoapache:masterfrom Aug 7, 2023
pegasas:util
Merged
[#434] refactor: New utility method to cover dynamic class loading in RSSUtils#1104roryqi merged 1 commit intoapache:masterfrom pegasas:util
roryqi merged 1 commit intoapache:masterfrom
pegasas:util
Conversation
Contributor
Author
|
try to resolve #434 |
Codecov Report
@@ Coverage Diff @@
## master #1104 +/- ##
============================================
+ Coverage 54.09% 55.29% +1.19%
- Complexity 2544 2545 +1
============================================
Files 386 366 -20
Lines 21882 19525 -2357
Branches 1811 1811
============================================
- Hits 11837 10796 -1041
+ Misses 9349 8104 -1245
+ Partials 696 625 -71
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Could you run the command to fix style issues? |
roryqi
changed the title
Contributor
Author
Sure. Will see why CI failed and fix it. |
roryqi
approved these changes
Aug 7, 2023
Contributor
Author
Thanks @jerqi for giving me a chance to uniffle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
New utility method to cover dynamic class loading in RSSUtils
Why are the changes needed?
Fix: #434
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI passed.