Skip to content

Conversation

@zwangsheng
Copy link
Contributor

@zwangsheng zwangsheng commented Aug 3, 2022

What changes were proposed in this pull request?

Remove StorageManagerFactory#createStorageManager useless server id

Why are the changes needed?

Clean code.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit test

@codecov-commenter
Copy link

Codecov Report

Merging #119 (7b4c2ec) into master (d2d60e2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #119   +/-   ##
=========================================
  Coverage     57.16%   57.16%           
  Complexity     1200     1200           
=========================================
  Files           150      150           
  Lines          8177     8177           
  Branches        773      773           
=========================================
  Hits           4674     4674           
  Misses         3257     3257           
  Partials        246      246           
Impacted Files Coverage Δ
.../uniffle/server/storage/StorageManagerFactory.java 58.33% <ø> (ø)
.../java/org/apache/uniffle/server/ShuffleServer.java 63.41% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@roryqi roryqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zwangsheng

@roryqi roryqi merged commit fce4bb6 into apache:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants