Skip to content

[#802] feat(spark): Implement ShuffleDataIo#1226

Merged
roryqi merged 5 commits intoapache:masterfrom
summaryzb:implement_shuffle_io
Oct 9, 2023
Merged

[#802] feat(spark): Implement ShuffleDataIo#1226
roryqi merged 5 commits intoapache:masterfrom
summaryzb:implement_shuffle_io

Conversation

@summaryzb
Copy link
Contributor

What changes were proposed in this pull request?

Implement ShuffleDataIo

Why are the changes needed?

#802

Does this PR introduce any user-facing change?

Yes. To use spark dynamicAllocation, user should set spark.shuffle.sort.io.plugin.class to org.apache.spark.shuffle.RssShuffleDataIo, otherwise spark3.5 will fail

How was this patch tested?

Integration test
Manual test

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2023

Codecov Report

Merging #1226 (afa1352) into master (fa6d162) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1226      +/-   ##
============================================
- Coverage     54.58%   54.55%   -0.03%     
  Complexity     2613     2613              
============================================
  Files           373      375       +2     
  Lines         20213    20224      +11     
  Branches       1929     1930       +1     
============================================
  Hits          11034    11034              
- Misses         8515     8526      +11     
  Partials        664      664              
Files Coverage Δ
...ava/org/apache/spark/shuffle/RssShuffleDataIo.java 0.00% <0.00%> (ø)
...ache/spark/shuffle/RssShuffleDriverComponents.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roryqi roryqi changed the title improvement: Implement ShuffleDataIo [#802] improvement: Implement ShuffleDataIo Oct 9, 2023
@roryqi roryqi changed the title [#802] improvement: Implement ShuffleDataIo [#802] feat(spark): Implement ShuffleDataIo Oct 9, 2023
Copy link
Contributor

@roryqi roryqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @summaryzb

@roryqi roryqi merged commit 98b0d12 into apache:master Oct 9, 2023
@summaryzb summaryzb deleted the implement_shuffle_io branch October 13, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants