[BUGFIX] Fix memory leak which cause oom #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
============================================
+ Coverage 57.20% 57.22% +0.02%
- Complexity 1200 1201 +1
============================================
Files 150 150
Lines 8185 8183 -2
Branches 773 772 -1
============================================
+ Hits 4682 4683 +1
+ Misses 3257 3255 -2
+ Partials 246 245 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jerqi
changed the title
Contributor
|
LGTM, cc @colinmjj |
Contributor
|
Thanks @summaryzb, Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
the behavior of buffer management and memory allocate
when adding a huge record to a partition where the buffer is not initialized, we only allocate bufferSegmentSize memory, however release the real huge size memory after the buffer is sent.
this will easily cause OOM.
Why are the changes needed?
better manage memory
Does this PR introduce any user-facing change?
no
How was this patch tested?
pass testing