[#1459] improvement(server): refactor DefaultFlushEventHandler and support event retry into pending queue #1461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and support event retry into pending queue
Member
Author
|
PTAL @jerqi @leixm @xianjingfeng |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1461 +/- ##
============================================
+ Coverage 54.19% 55.18% +0.99%
- Complexity 2775 2776 +1
============================================
Files 423 406 -17
Lines 24204 21876 -2328
Branches 2060 2063 +3
============================================
- Hits 13118 12073 -1045
+ Misses 10275 9058 -1217
+ Partials 811 745 -66 ☔ View full report in Codecov by Sentry. |
server/src/main/java/org/apache/uniffle/server/DefaultFlushEventHandler.java
Show resolved
Hide resolved
server/src/main/java/org/apache/uniffle/server/DefaultFlushEventHandler.java
Show resolved
Hide resolved
server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks for your review @xianjingfeng Merged. |
3 tasks
jerqi
pushed a commit
that referenced
this pull request
Apr 13, 2024
…nt is dropped (#1643) ### What changes were proposed in this pull request? Print an error log when an event is dropped. ### Why are the changes needed? A follow-up PR for: #1461. This way, it's easier to find error logs in the log, making it convenient for troubleshooting. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unnecessary.
jerqi
pushed a commit
that referenced
this pull request
May 6, 2024
…nt is dropped (#1643) ### What changes were proposed in this pull request? Print an error log when an event is dropped. ### Why are the changes needed? A follow-up PR for: #1461. This way, it's easier to find error logs in the log, making it convenient for troubleshooting. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unnecessary.
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
May 27, 2024
…and support event retry into pending queue (apache#1461) ### What changes were proposed in this pull request? 1. Refactor DefaultFlushEventHandler to unify the logic of handling event 2. Fix incorrect some metrics 3. Support retry event into pending queue 4. Fix the incorrect inFlushQueueSize 5. Introduce the underlying executor queue metrics ### Why are the changes needed? Fix: apache#1459 apache#1460 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #1459 #1460
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs