[MINOR] fix: Identify duplicate blocks in TestUtils.validateResult #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Do not check for blocks that have already been found in data stream.
Why are the changes needed?
The method
TestUtils.validateResultwould pass check of a data stream returned byreadClient.readShuffleBlockData()that contains duplicate blocks (let's say the first block inexpectedData) while overall cardinality of blocks match expectation (let's say that first block is duplicatedexpectedData.size()-times). Such a situation should throw an assertion error.Further, the inner loop can be left on match, which saves computation time.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Not tested.