[#1267][FOLLOWUP] improvement(client): INFO log level should be used in RetryUtils #1500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1500 +/- ##
============================================
+ Coverage 54.24% 55.28% +1.04%
- Complexity 2805 2808 +3
============================================
Files 427 407 -20
Lines 24349 21988 -2361
Branches 2077 2077
============================================
- Hits 13207 12157 -1050
+ Misses 10311 9074 -1237
+ Partials 831 757 -74 ☔ View full report in Codecov by Sentry. |
common/src/main/java/org/apache/uniffle/common/util/RetryUtils.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/uniffle/common/util/RetryUtils.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Should |
rickyma
force-pushed
the
followup-for-1267
branch
from
08041a4 to
3ca2744
Compare
… used in RetryUtils
rickyma
force-pushed
the
followup-for-1267
branch
from
3ca2744 to
1389b93
Compare
Contributor
Author
Done. @lifeSo |
Contributor
Author
We only show this detailed log in DEBUG level. |
smallzhongfeng
approved these changes
Feb 5, 2024
Contributor
smallzhongfeng
left a comment
smallzhongfeng
left a comment
There was a problem hiding this comment.
Waiting for CI, otherwise lgtm
Contributor
|
Thanks @rickyma Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
INFO log level should be used in RetryUtils. Because these log messages are not actual errors.
Why are the changes needed?
It's a followup PR for #1411.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.