[MINOR] refactor(common): Move blockId bit logic into common class #1527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnricoMi
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1527 +/- ##
============================================
+ Coverage 54.15% 55.20% +1.04%
- Complexity 2805 2816 +11
============================================
Files 431 412 -19
Lines 24421 22068 -2353
Branches 2081 2077 -4
============================================
- Hits 13226 12182 -1044
+ Misses 10363 9132 -1231
+ Partials 832 754 -78 ☔ View full report in Codecov by Sentry. |
Test Results2 452 files +14 2 452 suites +14 4h 42m 8s ⏱️ -22s Results for commit a134098. ± Comparison against base commit ff555c5. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Contributor
Author
EnricoMi
force-pushed
the
blockid-bit-logic
branch
2 times, most recently
from
4876aac to
da464d8
Compare
Member
|
Could you help review this? @jerqi |
Moves bit manipulation logic into common.util Reused in RssTezUtils and RssMRUtils
EnricoMi
force-pushed
the
blockid-bit-logic
branch
from
da464d8 to
a134098
Compare
jerqi
approved these changes
Feb 22, 2024
Contributor
jerqi
left a comment
jerqi
left a comment
There was a problem hiding this comment.
LGTM. Thanks @EnricoMi cc @zhengchenyu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Moves block id bit manipulation logic into one place in
common.util. Logic is tested once and reused everywhere. Reused inRssTezUtilsandRssMRUtilswhere reasonable. Aligns the order of arguments that constructs aBlockIdwith the bit-wise order inside the block id (highest to lowest).Why are the changes needed?
Reduces code duplication and improves code readability.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests.