Skip to content

[#1569] fix(rust): flaky test for test_ticket_manager#1570

Merged
smallzhongfeng merged 1 commit intomasterfrom
zuston-patch-1
Mar 8, 2024
Merged

[#1569] fix(rust): flaky test for test_ticket_manager#1570
smallzhongfeng merged 1 commit intomasterfrom
zuston-patch-1

Conversation

@zuston
Copy link
Member

@zuston zuston commented Mar 8, 2024

What changes were proposed in this pull request?

Use i64 to fix overflow rather than u64

Why are the changes needed?

Fix: #1569. to fix test_ticket_manager

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing uts

@zuston zuston requested a review from roryqi March 8, 2024 03:21
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.65%. Comparing base (d994b27) to head (df08df4).
Report is 264 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1570      +/-   ##
============================================
+ Coverage     53.72%   54.65%   +0.93%     
- Complexity     2838     2839       +1     
============================================
  Files           437      417      -20     
  Lines         24663    22302    -2361     
  Branches       2094     2094              
============================================
- Hits          13250    12189    -1061     
+ Misses        10581     9353    -1228     
+ Partials        832      760      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Mar 8, 2024

Test Results

 2 326 files  ±0  2 326 suites  ±0   4h 29m 43s ⏱️ +17s
   851 tests ±0    849 ✅ ±0   2 💤 ±0  0 ❌ ±0 
10 018 runs  ±0  9 995 ✅ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit df08df4. ± Comparison against base commit d994b27.

@smallzhongfeng smallzhongfeng merged commit cf6d2bf into master Mar 8, 2024
@smallzhongfeng
Copy link
Contributor

Thanks @zuston Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Flaky Test] test_ticket_manager for rust

3 participants