Skip to content

Conversation

@rickyma
Copy link
Contributor

@rickyma rickyma commented Mar 13, 2024

What changes were proposed in this pull request?

Handle all the exceptions when spilling buffers.
Let users know when a TimeoutException occurs.

Why are the changes needed?

Fix #1572.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.90%. Comparing base (142e3ff) to head (8f258fa).
Report is 211 commits behind head on master.

Files Patch % Lines
...pache/spark/shuffle/writer/WriteBufferManager.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1573      +/-   ##
============================================
+ Coverage     53.89%   54.90%   +1.00%     
- Complexity     2856     2858       +2     
============================================
  Files           437      418      -19     
  Lines         24748    22435    -2313     
  Branches       2103     2109       +6     
============================================
- Hits          13339    12318    -1021     
+ Misses        10577     9350    -1227     
+ Partials        832      767      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Test Results

 2 340 files  ±0   2 340 suites  ±0   4h 30m 34s ⏱️ -25s
   904 tests ±0     902 ✅ ±0   2 💤 ±0  0 ❌ ±0 
10 505 runs  ±0  10 482 ✅ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit 8f258fa. ± Comparison against base commit 9737d57.

@zuston zuston merged commit b2baef5 into apache:master Mar 14, 2024
@rickyma rickyma deleted the issue-1572 branch May 5, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Exceptions might be discarded when spilling buffers

3 participants