Skip to content

Conversation

@dingshun3016
Copy link
Contributor

@dingshun3016 dingshun3016 commented Mar 14, 2024

What changes were proposed in this pull request?

add client type when request shuffle assignment

Why are the changes needed?

Fix: (#1373)

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Not necessary.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.94%. Comparing base (f6569b0) to head (573344e).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1580      +/-   ##
============================================
+ Coverage     53.99%   54.94%   +0.94%     
+ Complexity     2862     2861       -1     
============================================
  Files           438      418      -20     
  Lines         24819    22458    -2361     
  Branches       2111     2111              
============================================
- Hits          13402    12339    -1063     
+ Misses        10578     9350    -1228     
+ Partials        839      769      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Test Results

 2 340 files  ±0   2 340 suites  ±0   4h 31m 45s ⏱️ -11s
   908 tests ±0     907 ✅ ±0   1 💤 ±0  0 ❌ ±0 
10 541 runs  ±0  10 527 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit 573344e. ± Comparison against base commit f6569b0.

Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But please fill the description .

@dingshun3016
Copy link
Contributor Author

LGTM. But please fill the description .

Thanks, the description has been filled

@zuston zuston merged commit 0b66472 into apache:master Mar 15, 2024
@zuston
Copy link
Member

zuston commented Mar 15, 2024

Merged. Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants