[ISSUE-76] Disallow sendShuffleData if requireBufferId expired #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could we add a ut for this pr? |
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
============================================
+ Coverage 57.17% 57.93% +0.76%
- Complexity 1201 1233 +32
============================================
Files 150 153 +3
Lines 8178 8250 +72
Branches 773 771 -2
============================================
+ Hits 4676 4780 +104
+ Misses 3256 3226 -30
+ Partials 246 244 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
reviewed
Aug 18, 2022
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcClient.java
Show resolved
Hide resolved
| int retryNum = 0; | ||
| while (retryNum < maxRetryAttempts) { | ||
| try { | ||
| long requireId = requirePreAllocation(size, request.getRetryMax(), request.getRetryIntervalMax()); |
jerqi
reviewed
Aug 18, 2022
| } | ||
|
|
||
| private SendShuffleDataResponse doSendData(SendShuffleDataRequest rpcRequest) { | ||
| private SendShuffleDataResponse doSendData(String appId, int size, RssSendShuffleDataRequest request, |
Contributor
There was a problem hiding this comment.
Method doXXXXX usually have one rpc operation. Could we encapsulate the behavior in the other places?
jerqi
changed the title
|
To avoid possible OOM in server side, LGTM, +1 |
Contributor
|
Merged. Thanks @xianjingfeng |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1.In server side, if requireBufferId not found when send data, thrown an exception.
2.In client side, if fail to send data, require buffer again.
Why are the changes needed?
We found shuffle server which under high load is easy encounter java.lang.OutOfMemoryError: Java heap space even we allocate more jvm heap memory and less rss.server.buffer.capacity #76
Does this PR introduce any user-facing change?
No
How was this patch tested?
Have already verify in our production enviroment.